Repository navigation
fix(nport): tickers for renamed issuers and u.s.-listed foreign issuers - #92
Merged
Merged
Conversation
Shared nport-reader block (workspace d7db168, open item Q33): a common stock with a foreign ISIN traded in USD keeps its ticker when the Nasdaq Trader symbol directories list it for the same company; renamed issuers resolve through the EDGAR-confirmed alias list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
nport-readerblock (workspaceetf-std/nport-reader.block.ts, open item Q33).nportTickerstakes the Nasdaq Trader symbol directories as a third argument: a common-stock row with a foreign ISIN traded in USD keeps a ticker whennasdaqlisted.txt/otherlisted.txtlist that ticker for the same company (nportUsListed: same name key, never a depositary or New York registry line); a local line in another currency, and every foreign row when the directories failed, still gets-. Renamed issuers resolve throughnportRenamedIssuers()(old N-PORT name -> ticker, only on the same CUSIP issuer number and while SEC still lists the ticker; 73 EDGAR-confirmed entries, e.g. Exxon Mobil -> XOM, Tempur Sealy -> SGI, Hartford Financial -> HIG)loadUsListingsloads both directories once per run through the SEC request helper of the N-PORT reader (readUsListings, null when either fails) and passes them tonportTickersWhy
U.S.-listed foreign issuers without a U.S. ISIN (Linde, Accenture, Chubb, NXP, IMAX, Lionsgate, Agnico Eagle, the Puerto Rico banks) and issuers whose SEC title changed after a rename or reorganization (ExxonMobil Holdings) published
-, so Copy Tickers and the Watchlist lost themEffect on real filings
Every fund of this feed with an N-PORT-P filing (92 filings, 39232 positions), newest filing read with the shared reader, old block (5935f58) vs this block on byte-identical cached SEC answers and directories of 2026-10-26; nothing written to
api/:Independent check over all 26 N-PORT brands: 761 of the 776 distinct restored identifier/ticker pairs equal OpenFIGI's U.S. ticker of that ISIN or CUSIP; for the other 15 OpenFIGI knows only a European line of the ISIN or not the CINS, and the Nasdaq Trader name confirms the company (Gates Industrial, Marex, Wave Life Sciences, Expro, Tecnoglass, Amcor, ...). No existing ticker moved to another security (0 moved above)
Checks
bun testandbun testwith everyupdate-data.config.jsoncontrol exported: 66 pass 0 fail, exit 0 bothbun build --target=bun scripts/update-data.ts --outfile=/dev/null,bun build --target=bun src/main.tsx --outfile=/dev/null,git diff --checkapply-block.ts --check nport-reader .: identical;tc/check.sh .: no new errors (52 lines, before 52)blocks.test.ts: 16 pass (renamed issuers, directories, foreign ISIN cases fail on the old block)