Repository navigation
Conversation
Signed-off-by: Edward Cheung <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by databricks/appkit-registry#11. The Designer runtime now ships as registry-installed source using released AppKit 0.89.0 public APIs. The consuming template is databricks/app-templates#296. A real Designer publish/build/run passed with that implementation; an SDK plugin release is no longer needed.
What did you change, and why?
Published Designer Apps currently carry their server implementation in the app template. Moving that runtime into AppKit lets templates use a small bootstrap and receive shared runtime fixes through a pinned SDK upgrade.
Adds the beta
designer()plugin, extracted from app-templates PR267 at commit2243222ae8bc486a4cc2c7bd07851f0d27ea4ff0:/api/designer, manifest v8, response shapes, viewer authorization, disabled-group handling, and the publisher's Job permission.createApp()calls and process-wide volume environment mutations with explicit per-request storage scopes. Caches belong to the plugin instance and are cleared on shutdown.@databricks/appkit/beta/designer. React rendering, tables/charts, HTML sandboxing, and browser recovery stay in the template.Most added code is extracted runtime/shared code and migrated regression tests. This PR does not switch the production template to an unpublished AppKit version. Follow-up sequence: AppKit release → template dependency and bootstrap migration → publisher template revision → App redeployment.
How do you know it works?
pnpm build,pnpm docs:build,pnpm -r typecheck, lint/format and package export checks passed. Docs reports an existing broken telemetry anchor outside this change.The pre-commit Knip check reports the same unused
packages/appkit/bin/appkit.jsand rootesbuild,ora,zoddependencies on unchangedmain. New unused exports were fixed; the remaining baseline-only findings were verified using a clean archive of main. The hook was skipped for the commit after the checks above passed.