Repository navigation
Register existing file state into best-effort deployment history - #7171
Draft
shreyas-goenka wants to merge 1 commit into
Conversation
Contributor
|
Commit: Regression test reportSelected 20 changed tests (limit=20, 8 not selected) 21 tests: regression=19 unreleased=0 coverage=2 failing=0
TestAccept/bundle/deploy/readplan/lineage-mismatch/DMS=true: branch ✅ | main (4d88efe) ❌ | latest (v1.22.1) ❌main (4d88efe): latest (v1.22.1): same output as main (4d88efe) TestAccept/bundle/dms/bind-unbind-unsupported/DMS=true: branch ✅ | main (4d88efe) ❌ | latest (v1.22.1) ❌main (4d88efe): latest (v1.22.1): same output as main (4d88efe) TestAccept/bundle/dms/declined-deploy/DMS=true: branch ✅ | main (4d88efe) ❌ | latest (v1.22.1) ❌main (4d88efe): latest (v1.22.1): TestAccept/bundle/dms/depends-on/DMS=true: branch ✅ | main (4d88efe) ❌ | latest (v1.22.1) ❌main (4d88efe): latest (v1.22.1): TestAccept/bundle/dms/deployment-metadata-change/DMS=true: branch ✅ | main (4d88efe) ❌ | latest (v1.22.1) ❌main (4d88efe): latest (v1.22.1): same output as main (4d88efe) TestAccept/bundle/dms/existing-state/DMS=: branch ✅ | main (4d88efe) ❌ | latest (v1.22.1) ❌main (4d88efe): latest (v1.22.1): same output as main (4d88efe) TestAccept/bundle/dms/failed-delete/DMS=true: branch ✅ | main (4d88efe) ❌ | latest (v1.22.1) ❌main (4d88efe): latest (v1.22.1): same output as main (4d88efe) TestAccept/bundle/dms/failed-recreate/DMS=true: branch ✅ | main (4d88efe) ❌ | latest (v1.22.1) ❌main (4d88efe): latest (v1.22.1): TestAccept/bundle/dms/migration-before-deploy/DMS=true: branch ✅ | main (4d88efe) ❌ | latest (v1.22.1) ❌main (4d88efe): latest (v1.22.1): TestAccept/bundle/dms/migration-fails-open/DMS=true: branch ✅ | main (4d88efe) ❌ | latest (v1.22.1) ❌main (4d88efe): latest (v1.22.1): same output as main (4d88efe) 9 more failure details omitted, see the full report in the run. |
Collaborator
Integration test reportCommit: 482da0c
Top 20 slowest tests (at least 2 minutes):
|
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
3 times, most recently
from
October 26, 2026 05:16
f9da0d8 to
10da8f6
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 05:25
4017609 to
0b70621
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 05:25
10da8f6 to
e4f88b3
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 05:35
0b70621 to
d2f84b5
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 05:35
e4f88b3 to
06e09d2
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 09:41
d2f84b5 to
7767812
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 09:41
06e09d2 to
a682521
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 10:00
7767812 to
fd7ab56
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 10:00
a682521 to
4661cf7
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 10:04
fd7ab56 to
9ca0c3e
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 10:04
4661cf7 to
24b5917
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 10:19
9ca0c3e to
30e3aef
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 10:19
24b5917 to
6a7fbc8
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 10:34
30e3aef to
e977af6
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 10:34
6a7fbc8 to
ee4757c
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 10:36
e977af6 to
0471b06
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 10:36
ee4757c to
10360b9
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 10:47
0471b06 to
8542de3
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 10:47
10360b9 to
eeb8a3f
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 10:58
8542de3 to
f1e49cf
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 10:58
eeb8a3f to
98b7afd
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 11:09
f1e49cf to
ed3ba2e
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 11:09
98b7afd to
97c8e12
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 11:21
ed3ba2e to
8692c4f
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 11:21
97c8e12 to
fa7bad4
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 11:37
8692c4f to
8ca44ba
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 11:37
fa7bad4 to
a0f283d
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 12:34
8ca44ba to
49f895d
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 12:34
a0f283d to
f0b19b7
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 13:01
49f895d to
91e0249
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 13:01
f0b19b7 to
4985114
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 13:09
91e0249 to
8f9a4fa
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 13:09
4985114 to
67edb09
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 13:21
8f9a4fa to
bbd5aa4
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 13:22
67edb09 to
4b60136
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 14:04
bbd5aa4 to
7d6a9cf
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 14:04
4b60136 to
d5ba271
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 14:20
7d6a9cf to
de2849a
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 14:20
d5ba271 to
303c00e
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-default
branch
from
October 26, 2026 14:36
de2849a to
83de547
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 14:36
303c00e to
6dad80f
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/history-best-effort-migration
branch
from
October 26, 2026 16:02
6dad80f to
482da0c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling best-effort history through YAML or the environment flag now attempts
INITIAL_REGISTERfor existing file state before normal deployment planning. IDs, payloads, and dependencies remain inresources.json. Empty snapshots skip registration versions.max(file serial, latest DMS version) + 1, and persist the enforced-history marker as a separate phase.Saved plans cannot enable initial registration; Terraform state must first migrate to direct with history disabled. Existing DMS-only state remains supported.
Stack: #7151 → #7169 → #7171 (this PR). Adapts #6989.
Validation: affected Go/race tests and lint pass. Acceptance coverage checks backups, IDs/dependencies, repeat registration, planning failure/decline, environment-only opt-in, and fail-open uploads. Regression tests cover state changing before migration and independent file/service counters.