Repository navigation
Conversation
Collaborator
|
reopen when it is not a draft |
ABACUS-PR-BOT
left a comment
Collaborator
There was a problem hiding this comment.
Static review at f34f8ee found no implementation defect in the shared output preparation, readiness gate, or source renames. A regression coverage suggestion follows. No builds, runtime tests or CI diagnostics were performed; author-reported checks were not independently rerun.
| const std::string& global_out_dir = PARAM.globalv.global_out_dir; | ||
| const bool latest_ready = (iter > 1 || istep > 0); | ||
| if (latest_ready) | ||
| const bool occmat_ready = (iter > 1 || istep > 0 || this->dftu_->is_occmat_ready()); |
Collaborator
There was a problem hiding this comment.
Non-blocking: The existing tests exercise loaded readiness and output helpers separately, so they would still pass if this gate reverted to iter > 1 || istep > 0. Add a one-step file-loaded PW restart case that checks occ_mat.txt contains the first-step matrix, with a fresh-start control and a check that numbered output does not retain stale sections.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ESolver_KS::iter_init()for both PW and LCAO.iter_init_dftu_pw()andfinish_dftu_lcao().dftu_base_io_read.cppanddftu_base_io_write.cpptodftu_base_read.cppanddftu_base_write.cpp, updating CMake and legacy Makefile source lists. The renamed source contents are unchanged.occ_mat.txtat the first electronic step as well as the numbered snapshot. Both output calls now use the same readiness condition; fresh PW calculations still wait until the matrix is available.Verification
python3 tools/03_code_analysis/agent_governance_check.py --stagedcheck reported no errors.cmake -S . -B /tmp/abacus-dftu-rename-build -DBUILD_TESTING=ON -DENABLE_LCAO=ON -DENABLE_MPI=ON -DENABLE_LIBXC=OFF -DENABLE_EXX=OFF -DENABLE_DEEPKS=OFF -DENABLE_CUDA=OFF -DENABLE_ROCM=OFFcompleted. CMake reported that the ENABLE_EXX/DEEPKS/CUDA/ROCM variables were unused.cmake --build /tmp/abacus-dftu-rename-build --target MODULE_PW_dftu_base_test MODULE_DFTU_base_io -j 8: both targets built.OMP_NUM_THREADS=1 /tmp/abacus-dftu-rename-build/source/source_pw/module_pwdft/unittests/MODULE_PW_dftu_base_test --gtest_brief=1: 27/27 passed.OMP_NUM_THREADS=1 /tmp/abacus-dftu-rename-build/source/source_lcao/module_dftu/unittests/MODULE_DFTU_base_io --gtest_brief=1: 6/6 passed.git diff --checkandgit diff --cached --check: passed.Review notes
PARAM.globalv.global_out_dirreference moved from the PW solver call site to the shared KS solver in the earlier commit; the PR-wide global dependency count is unchanged.ESolver_KSprepares ion-step output for both basis paths; PW iteration finish uses the existing matrix-readiness state for both outputs.ESolver_KSfixture would substantially expand this PR. Full PW/LCAO runtime validation remains for CI/review.