Repository navigation
new icon: groq (original, original-wordmark, plain-wordmark) - #2817
KekMuzaffer wants to merge 8 commits into
Conversation
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
Yashh56
left a comment
There was a problem hiding this comment.
Hey @KekMuzaffer, thanks for this PR. I reviewed and suggested some changes kindly look at them.
| }, | ||
| { | ||
| "name": "idris", | ||
| "altnames": ["idris2"], | ||
| "tags": [ | ||
| "language", | ||
| "functional" | ||
| ], | ||
| "versions": { | ||
| "svg": [ | ||
| "original" | ||
| ], | ||
| "font": [ | ||
| "original" | ||
| ] | ||
| }, | ||
| "color": "#8a0819", | ||
| "aliases": [ | ||
| { | ||
| "base": "original", | ||
| "alias": "plain" | ||
| } | ||
| ] |
There was a problem hiding this comment.
Please Undo these changes. A single PR should only contains a Single Icon.
Also, sort the position of groq object as well.
There was a problem hiding this comment.
I don't think this is the logo they use right now. please reverify.
There was a problem hiding this comment.
Since the original-wordmark have single path we don't need this. kindly delete this
|
@Yashh56, thanks for the suggestions! Before making any changes, I think we should clarify a few points, as the current icon is somewhat misleading. Unfortunately, I haven't been able to determine which icon should be considered the official one. I also used AI as a research tool to help identify the official Groq icon. The following sources served as references: Based on my research, Groq appears to use two different icon variations:
Could you clarify which of these variants should be used as the official icon for this project? What's your take on this, @Snailedlt? |











Double check these details before you open a PR
developbranch.devicon.jsonfile at the correct alphabetic position as seen hereThis PR closes #2655
Link to prove your SVG is correct and up-to-date.
Summary
Added
groqicon to the devicon collection with three SVG variants.groq-original.svggroq-original-wordmark.svggroq-plain-wordmarkIcon Details
Repository Structure
Please note