Skip to content

Drop PYTHONIOENCODING for Python >= 3.16 #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yosifkit merged 1 commit into from
Oct 23, 2026
+8 −6
Merged

Drop PYTHONIOENCODING for Python >= 3.16 #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions 3.16-rc/windows/windowsservercore-ltsc2022/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions 3.16-rc/windows/windowsservercore-ltsc2025/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions Dockerfile-windows.template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
{{
def rcVersion:
env.version | rtrimstr("-rc")
;
def extension:
.checksums.windows.url | split(".")[-1]
;
Expand All @@ -8,9 +11,14 @@
FROM mcr.microsoft.com/windows/{{ env.windowsVariant }}:{{ env.windowsRelease }}

SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]
{{ if rcVersion | IN("3.11", "3.12", "3.13", "3.14", "3.15") then ( -}}

{{ # only set PYTHONIOENCODING on versions less than 3.16 -}}
# https://github.com/docker-library/python/pull/557
ENV PYTHONIOENCODING UTF-8
{{ # reproducer: docker run --rm python:{{ env.version }}-windowsservercore-{{ env.windowsRelease }} python -c 'print(chr(0x4e2d))' -}}
{{ # https://github.com/docker-library/python/pull/1144#pullrequestreview-5634536246 -}}
{{ ) else "" end -}}
{{
# installer sets path for older python, but needs to be set for the zip download
if is_windows_zip then (
Expand Down
Loading