Repository navigation
Conversation
th0rntwig
force-pushed
the
feat/entity-linking
branch
2 times, most recently
from
September 3, 2026 11:58
ac745f6 to
6f6e6be
Compare
th0rntwig
force-pushed
the
feat/entity-linking
branch
from
November 1, 2026 13:19
cfa4c8f to
efa4a5d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔴 Review tier: HIGH — human review required
CirrusMetadatafields optionalmainpublishes to PyPIWhat this does
Adds wiki batch search, entity linking and QID lookup to the Python SDK, on both
WikiAPIandAsyncWikiAPI:search_wiki_batchPOST /v1/wiki/search/batchlink_entityGET /v1/wiki/link-entitylink_entity_batchPOST /v1/wiki/link-entity/batchget_entityGET /v1/wiki/entity/{qid}get_entity_batchPOST /v1/wiki/entity/batchsearch_wikialso gainshas_wikidata.Contract
relevance_threshold0.40,ambiguity_margin0.05,allow_ambiguoustrue,n_candidates5,include_candidatesfalse. Batch settings go in the request body.WikidataMetadatafields in the same order as stories-service and the gateway, with all three chunk IDs declared.None: there is no None-exclusion, so a dump includes unset fields as nulls.extra="allow"onWikidataMetadataand its value models: a property served after a caller's SDK version still arrives onmodel_extra. stories-service and the gateway keep the metadata model closed, because they decide what is public.n_candidates, thresholds and batch size vary by route or plan, so the gateway rejects out-of-range values. The SDK checks only empty entity names, empty QIDs and thatentity_typesandentity_descriptionsmatchentitiesin length.Worth checking
link_statusbefore trustinglinked_entity. It isnullforno_match, and forambiguouswhenallow_ambiguousis false.search_wikidefaults ton_documents=10, while the gateway defaults to 5. This predates the PR and is unchanged here.Testing
pytest -q: 228 passed.Rollout
Merge after the gateway is deployed (api !387), because merging publishes to PyPI and these methods call its routes. mcp-service installs the published SDK, so its new wiki tools can only be verified after this release.
Umbrella:
em-hub/features/wiki-entity-linking/README.md🤖 Generated with Claude Code