Repository navigation
Conversation
run-tests.sh checked $? after the rm that cleaned up the temporary files, so
it saw the exit status of rm and the suite never failed on a mismatch. It now
checks the result of diff directly.
The line-number pattern used \d, which sed does not understand, so line
numbers were never normalised. It now uses [0-9]\{1,\}.
std::ptr_fun and std::not1 were removed in C++17, so helpers.h now uses a
lambda instead.
Co-authored-by: Michael Allwright <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
iHiD
added this pull request to stack #111
October 22, 2026 04:26
The expected results stored the exact compiler output, which changes with every compiler upgrade. For example, example-empty-file was recorded with GCC 12.2.1 in 2023 and the image now has GCC 15.2.0. Build errors are now compared by their status, so the suite no longer breaks when the compiler changes. Co-authored-by: Michael Allwright <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]>
vaeng
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This description was written by Claude (Claude Code), not by iHiD.
This pulls the bug fixes out of #106 so they can be reviewed on their own. It is stacked on #109.
bin/run-tests.shcompares each test's results with its expected results. It checked whether that comparison had failed only after deleting the temporary files, so it was really checking whether the delete worked. A test with the wrong results showed a diff in the log, but the run still passed.\d) isn't something sed understands, so nothing was ever replaced.tests/example-empty-filedid. Its expected results hold the linker's exact error message, recorded with GCC 12.2.1 in 2023. The image now has GCC 15.2.0, whose message has a different path and an extra offset. Build errors are now compared on their status only, so compiler upgrades don't break the suite.bin/run.shused bash features while declaringsh. Alpine'sshhappens to accept them, which is why it works in the Docker image, but anyshthat sticks to the standard would fail on them.include/helpers.husedstd::ptr_fun, which was removed from the language in C++17. GCC still accepts it, but clang with libc++ does not. It now uses a lambda, which does the same thing.🤖 Generated with Claude Code