Repository navigation
Conversation
Port Yashvardhan Thanvi's implementation and regression tests from microsoft/debugpy#2086 into PyDev.Debugger without the vendoring prefix. This preserves the original implementation author's credit; lollipoll prepared and independently validated the upstream port with Codex. Original commits: 495e26689f1d6c90b211a067ec5f83b2a0fae5e2 1d42f0abe74aec8e8b543233a28ef5bf732d8854 Fixes fabioz#265.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port microsoft/debugpy#2086 to fix archive-boundary detection in PyDev.Debugger. Ordinary directory names such as
.zipx,archive.zip_andbar.egg-infocurrently get split as archives, so breakpoints in existing files are rejected as nonexistent. The same split can also make a missing path appear to exist inside a similarly named ZIP.The implementation and regression tests are by Yashvardhan Thanvi in microsoft/debugpy#2086 (commits
495e26689f1d6c90b211a067ec5f83b2a0fae5e2and1d42f0abe74aec8e8b543233a28ef5bf732d8854). This ports those changes without the debugpy vendoring prefix. Archive components are checked from left to right, require an actual path boundary, and skip directories on disk that happen to end in.zipor.egg.Fixes #265.
Validation on Linux / Python 3.12.3:
git diff --checkpasses. Ruff reports the same 36 existing lint findings and the same two files needing formatting on the unmodified base; the port does not add new lint findings.AI assistance: OpenAI Codex retrieved and ported the existing contribution, ran the local checks, and prepared this submission. The original implementation and tests remain credited to their author. Maintainer review and CI remain necessary before merging.