Repository navigation
Fix memory leak in str() of fmpz_mpoly, fmpq_mpoly, fmpz_mod_mpoly, nmod_mpoly - #436
Merged
Merged
Conversation
Comment on lines
+3969
to
+3976
| def _peak_rss_mb() -> float: | ||
| """Peak resident set size of this process in MB (``resource`` is Unix only).""" | ||
| import resource | ||
| peak = resource.getrusage(resource.RUSAGE_SELF).ru_maxrss | ||
| return peak / (2**20 if platform.system() == "Darwin" else 1024) | ||
|
|
||
|
|
||
| def test_mpoly_str_does_not_leak(): |
Collaborator
There was a problem hiding this comment.
We don't need this kind of test for a memory leak once it is fixed.
Contributor
Author
There was a problem hiding this comment.
Removed the test in a new commit
Removing unnecessary test
Collaborator
|
Looks good. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #435