Repository navigation
Conversation
Member
|
Hello @Mokto, I see 2 options to include your provider to the list of providers:
My preference goes for the first option because that's how it's done for all other global/worldwide providers but decision is obviously yours to make. |
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the OpenGeocoding provider (address search and reverse geocoding) to the monorepo as
geocoder-php/opengeocoding-provider, instead of linking to a third-party package. This follows the maintainer's suggestion to migrate the provider intosrc/Provider. The code, tests and recorded responses come unchanged from the standaloneMokto/geocoder-php-opengeocoding-providerrepository.Changes
src/Provider/OpenGeocoding, with its ownOpenGeocodingAddressmodel (display name, match quality, distance, layer).OPENGEOCODING_API_KEYadded to the rootphpunit.xml.dist.README.md; the provider README tells users not to install it alongside the oldopengeocoding/opengeocoding-providerpackage.Review focus
Publishing is left to the maintainer: the split repository and Packagist package still need to be created. The standalone repository and its package are untouched.