Skip to content

Add OpenGeocoding provider to src/Provider - #1277

Open
Mokto wants to merge 2 commits into
geocoder-php:masterfrom
Mokto:add-opengeocoding-provider
Open

Mokto wants to merge 2 commits into
geocoder-php:masterfrom
Mokto:add-opengeocoding-provider

Conversation

@Mokto

@Mokto Mokto commented Oct 29, 2026 •

Copy link
Copy Markdown

Summary

Adds the OpenGeocoding provider (address search and reverse geocoding) to the monorepo as geocoder-php/opengeocoding-provider, instead of linking to a third-party package. This follows the maintainer's suggestion to migrate the provider into src/Provider. The code, tests and recorded responses come unchanged from the standalone Mokto/geocoder-php-opengeocoding-provider repository.

Changes

  • New provider in src/Provider/OpenGeocoding, with its own OpenGeocodingAddress model (display name, match quality, distance, layer).
  • Provider CI job and subtree split entry registered, and OPENGEOCODING_API_KEY added to the root phpunit.xml.dist.
  • Provider listed in the root README.md; the provider README tells users not to install it alongside the old opengeocoding/opengeocoding-provider package.
  • Tests use cached responses, so no live API calls are made.

Review focus

Publishing is left to the maintainer: the split repository and Packagist package still need to be created. The standalone repository and its package are untouched.

@jbelien

jbelien commented Nov 1, 2026

Copy link
Copy Markdown
Member

Hello @Mokto,

I see 2 options to include your provider to the list of providers:

  • Migrate your provider to this repository in src/Provider by making a Pull Request ; I'll take care of publishing it
  • Split "World" from "World (Third-party)" in the README.md

My preference goes for the first option because that's how it's done for all other global/worldwide providers but decision is obviously yours to make.

@Mokto Mokto changed the title Add OpenGeocoding (third-party package) to the providers list Add OpenGeocoding provider to src/Provider Nov 1, 2026
@Mokto

Mokto commented Nov 1, 2026

Copy link
Copy Markdown
Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants