Repository navigation
ref(deno): Use a shared request handler wrapper for Deno.serve - #25586
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦Compared: 3555c35 (PR test merge using develop at d66dbfd) Against: ad71ef6 (develop) · base run #63604
|
isaacs
force-pushed
the
isaacschlueter/js-3975-share-one-request-handler-wrapper-across-denoserve-bunserve
branch
from
October 21, 2026 00:49
0e901b1 to
bf847fb
Compare
isaacs
marked this pull request as ready for review
October 21, 2026 00:49
isaacs
requested review from
andreiborza and
mydea
and removed request for
a team
October 21, 2026 00:49
isaacs
force-pushed
the
isaacschlueter/js-3975-share-one-request-handler-wrapper-across-denoserve-bunserve
branch
from
October 21, 2026 01:07
bf847fb to
e2c327d
Compare
isaacs
force-pushed
the
isaacschlueter/js-3975-share-one-request-handler-wrapper-across-denoserve-bunserve
branch
from
October 21, 2026 01:13
e2c327d to
904c22c
Compare
isaacs
force-pushed
the
isaacschlueter/js-3975-share-one-request-handler-wrapper-across-denoserve-bunserve
branch
2 times, most recently
from
October 21, 2026 01:20
997d5b5 to
415525c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 415525c. Configure here.
isaacs
force-pushed
the
isaacschlueter/js-3975-share-one-request-handler-wrapper-across-denoserve-bunserve
branch
from
October 21, 2026 04:14
6bfff61 to
c992cee
Compare
mydea
reviewed
Oct 21, 2026
isaacs
force-pushed
the
isaacschlueter/js-3975-share-one-request-handler-wrapper-across-denoserve-bunserve
branch
from
October 21, 2026 14:16
c992cee to
dacacf0
Compare
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 5 not successful, 55 successful. See the run.
Successful checks
|
isaacs
force-pushed
the
isaacschlueter/js-3975-share-one-request-handler-wrapper-across-denoserve-bunserve
branch
from
October 21, 2026 17:10
dacacf0 to
e0c1017
Compare
isaacs
force-pushed
the
isaacschlueter/js-3975-share-one-request-handler-wrapper-across-denoserve-bunserve
branch
from
October 21, 2026 17:28
e0c1017 to
426ab70
Compare
isaacs
force-pushed
the
isaacschlueter/js-3975-share-one-request-handler-wrapper-across-denoserve-bunserve
branch
from
October 21, 2026 18:27
6baab78 to
51a13db
Compare
isaacs
force-pushed
the
isaacschlueter/js-3975-share-one-request-handler-wrapper-across-denoserve-bunserve
branch
from
October 21, 2026 18:37
51a13db to
cc1949a
Compare
isaacs
force-pushed
the
isaacschlueter/js-3975-share-one-request-handler-wrapper-across-denoserve-bunserve
branch
2 times, most recently
from
October 22, 2026 15:37
5a4a067 to
7f39034
Compare
isaacs
force-pushed
the
isaacschlueter/js-3975-share-one-request-handler-wrapper-across-denoserve-bunserve
branch
4 times, most recently
from
October 23, 2026 20:54
649937a to
fb05427
Compare
JPeer264
self-requested a review
October 25, 2026 23:29
isaacs
force-pushed
the
isaacschlueter/js-3975-share-one-request-handler-wrapper-across-denoserve-bunserve
branch
2 times, most recently
from
October 26, 2026 18:17
4a8f2f9 to
05a15aa
Compare
Deno.serve, Bun.serve and Cloudflare each wrap a web `Request` handler with their own copy of the same steps: request data and body, the `http.server` span, streamed responses, errors and sessions. The copies drift, so a fix in one runtime does not reach the others. This adds `wrapServerRequestHandler` to `@sentry/server-utils` and moves `Deno.serve` onto it. Bun.serve and Cloudflare follow in separate PRs, so each runtime's changes can be reviewed alone. The wrapper has only what Deno needs today, and the next PRs extend it. It is exported from the shared entry, so the Node-free `@sentry/server-utils/no-diagnostic-channels` entry can use it too. The rules follow core's `node:http` server code. `OPTIONS` and `HEAD` requests get no span and no body capture, but still get request data, a session and error capture. The static asset filter applies only to `GET`. For streamed responses, the wrapper uses the stream monitor from the Bun SDK, which reads only when the client pulls and reports errors from the stream source. It replaces Deno's own copy, which read ahead of the client and ignored source errors. The existing Deno tests pass with no change. Visible changes for Deno: - An error from the source of a streamed response is now captured, and the span gets an error status. - The SDK no longer reads a streamed response ahead of the client. - Errors in `OPTIONS` and `HEAD` requests now carry the request data. - `client.address` is no longer set to the path of a Unix socket. Part of #25577 Part of JS-3975 Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
isaacs
force-pushed
the
isaacschlueter/js-3975-share-one-request-handler-wrapper-across-denoserve-bunserve
branch
from
October 26, 2026 18:20
05a15aa to
1153ee8
Compare
JPeer264
approved these changes
Oct 26, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
The code has one regression, but once this is fixed it is ready to be shipped: AbortError a client disconnect seems to send an internal_error instead.
JPeer264
approved these changes
Oct 26, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
The code has one regression, but once this is fixed it is ready to be shipped: AbortError a client disconnect seems to send an internal_error instead.
Member
Author
Good catch! Fixed. |
isaacs
deleted the
isaacschlueter/js-3975-share-one-request-handler-wrapper-across-denoserve-bunserve
branch
October 26, 2026 23:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deno.serve, Bun.serve and Cloudflare each wrap a web
Requesthandler with their own copy of the same steps: request data and body, thehttp.serverspan, streamed responses, errors and sessions. The copies drift, so a fix in one runtime does not reach the others.This adds
wrapServerRequestHandlerto@sentry/server-utilsand movesDeno.serveonto it. Bun.serve and Cloudflare follow in separate PRs, so each runtime's changes can be reviewed alone. The wrapper has only what Deno needs today, and the next PRs extend it. It is exported from the shared entry, so the Node-free@sentry/server-utils/no-diagnostic-channelsentry can use it too.The rules follow core's
node:httpserver code.OPTIONSandHEADrequests get no span and no body capture, but still get request data, a session and error capture. The static asset filter applies only toGET. For streamed responses, the wrapper uses the stream monitor from the Bun SDK, which reads only when the client pulls and reports errors from the stream source. It replaces Deno's own copy, which read ahead of the client and ignored source errors.The existing Deno tests pass with no change. Visible changes for Deno:
OPTIONSandHEADrequests now carry the request data.client.addressis no longer set to the path of a Unix socket.Part of #25577
Part of JS-3975