Repository navigation
feat(boto3): Use object.* ops for S3 Object operations - #8037
Merged
Merged
Conversation
pabloDeputter
marked this pull request as ready for review
October 14, 2026 18:22
Contributor
Coverage Results 📊✅ 57426 passed | ⏭️ 2943 skipped | Total: 60369 | Pass Rate: 95.12% | Execution Time: 159m 59s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00% (14 of 14 changed executable lines covered; target 80%). Changed files with executable lines (2)
Generated by Coverage Action |
sentrivana
approved these changes
Oct 15, 2026
sentrivana
left a comment
Collaborator
There was a problem hiding this comment.
If the associated conventions PRs are approved this looks good to me.
pabloDeputter
force-pushed
the
pablo/boto3-default-rpc-op
branch
from
October 15, 2026 13:38
72498a1 to
c153076
Compare
pabloDeputter
force-pushed
the
pablo/boto3-s3-object-ops
branch
from
October 16, 2026 15:27
e9f873f to
64bf8c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
S3 object operations now override default
rpcop withobject.*. Other S3 operations, e.g.ListBuckets, stay onrpc.(
object.copy, which will be added in feat(ops): Addobject.copyop sentry-conventions#706 .object.*name/description rules (feat(names): Add span name and description rules forobject.*ops sentry-conventions#707) and theobjectspan category (feat(normalization): Deriveobjectspan category relay#6514, feat(attributes): Add object to thesentry.categoryvalues sentry-conventions#721) are yet to be added; otherwise nodescriptionis inferred for theobject.*spans.)
(todo: update migration guide, like in the PR before)