Skip to content

docs(core): Drop stale logger.warn note from AGENTS.md - #6968

Open
antonis wants to merge 1 commit into
mainfrom
docs/agents-md-stale-turbomodule-notes
Open

antonis wants to merge 1 commit into
mainfrom
docs/agents-md-stale-turbomodule-notes

Conversation

@antonis

@antonis antonis commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Docs-only update to the TurboModule section of packages/core/AGENTS.md, removing two gotchas that describe already-fixed bugs:

💡 Motivation and Context

Agents read this file as current truth; stale "known bug" notes invite them to "fix" code that is already correct.

💚 How did you test it?

  • grep -rn "logger\." packages/core/src/js/turbomodule/ returns nothing.
  • Checked the remaining gotchas (RNSENTRY_SKIP, default ignoreTurboModules, synchronous crash-attribution pop, no production native sink) against the code — still accurate.
  • yarn lint:lerna passes.

📝 Checklist

  • I added tests to verify changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.
  • No breaking changes.

🔮 Next steps

Also replaces the ~0ms callback-style gotcha, fixed by #6561, with the
current behaviour and lists turboModuleCallbacks.ts in the file table.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@github-actions

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • docs(core): Drop stale logger.warn note from AGENTS.md by antonis and claude in #6968

🤖 This preview updates automatically when you update the PR.

@github-actions

Copy link
Copy Markdown
Contributor
Fails
🚫 Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

Generated by 🚫 dangerJS against 03f55a1

@antonis
antonis marked this pull request as ready for review October 29, 2026 14:45
@antonis
antonis requested review from a team and lucas-zimerman as code owners October 29, 2026 14:45
@antonis
antonis requested review from alwx and buenaflor and removed request for a team October 29, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TurboModule instrumentation: callback-style bridge methods are recorded as ~0ms sync calls

1 participant