Repository navigation
Conversation
Also replaces the ~0ms callback-style gotcha, fixed by #6561, with the current behaviour and lists turboModuleCallbacks.ts in the file table. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
antonis
marked this pull request as ready for review
October 29, 2026 14:45
antonis
requested review from
alwx and
buenaflor
and removed request for
a team
October 29, 2026 14:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Docs-only update to the TurboModule section of
packages/core/AGENTS.md, removing two gotchas that describe already-fixed bugs:loggervsdebug: keeps the rule (loggerfrom@sentry/coreis the Logs API and recurses through the wrappedRNSentry.captureEnvelope), drops the call counts and the "pre-existing calls are a known bug" note. fix(core): Use the debug logger, not the Logs API, for SDK diagnostics #6585 moved all ofsrc/js/turbomodule/todebug.warn.turboModuleCallbacks.ts, closed TurboModule instrumentation: callback-style bridge methods are recorded as ~0ms sync calls #6542). The bullet now describes current behaviour, andturboModuleCallbacks.tsis added to the data-flow file table.💡 Motivation and Context
Agents read this file as current truth; stale "known bug" notes invite them to "fix" code that is already correct.
💚 How did you test it?
grep -rn "logger\." packages/core/src/js/turbomodule/returns nothing.RNSENTRY_SKIP, defaultignoreTurboModules, synchronous crash-attribution pop, no production native sink) against the code — still accurate.yarn lint:lernapasses.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps