Repository navigation
Conversation
owen-mc
changed the title
owen-mc
force-pushed
the
java/char-filtering-callable
branch
from
October 20, 2026 11:55
5a0f3af to
e010681
Compare
owen-mc
marked this pull request as ready for review
October 21, 2026 13:57
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved flow-inference errors cause false alerts and missed sensitive logging.
7 open issues
What changed in this PR
Extends java/sensitive-log to follow sensitive data through Java character-filtering helpers.
Changes:
- Infer flow through character-copying loops and output parameters.
- Integrate inferred flow into sensitive logging analysis.
- Add positive and negative regression cases with expected results.
| File | Description |
|---|---|
java/ql/test/query-tests/security/CWE-532/SensitiveLogInfo.expected |
Updates expected alerts and flow paths. |
java/ql/test/query-tests/security/CWE-532/CharacterFilteringTest.java |
Adds filtering and non-preserving transformation cases. |
java/ql/lib/semmle/code/java/security/SensitiveLoggingQuery.qll |
Enables character-filtering flow steps. |
java/ql/lib/semmle/code/java/dataflow/CharacterFiltering.qll |
Implements character-filtering summary inference. |
Review effort: Max
| DataFlow::localFlowStep(source, sink) | ||
| or | ||
| exists(MethodCall conversion | | ||
| conversion.getMethod().hasQualifiedName("java.lang", "Character", ["toChars", "toString"]) and |
| */ | ||
| predicate characterFilteringCallStep(DataFlow::Node input, DataFlow::Node output) { | ||
| exists(MethodCall call, int inputPosition, LocalScopeVariable filteredOutput | | ||
| characterFilteringOutput(call.getMethod(), inputPosition, filteredOutput) and |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.