Repository navigation
Unified: Add extensions convenience predicates - #22867
Merged
Merged
Conversation
hvitved
force-pushed
the
unified/extensions-convenience
branch
2 times, most recently
from
October 22, 2026 08:08
42f7686 to
1d10583
Compare
hvitved
marked this pull request as ready for review
October 22, 2026 08:12
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Extension ownership and type-alias resolution still produce incorrect or incomplete results.
4 open issues
What changed in this PR
This PR adds extension-aware navigation to the Unified AST library and applies it to naming, type inference, and legacy model matching.
Changes:
- Add
getAMemberIncludingExtensions()andgetParentClass(). - Centralize qualified-name handling while keeping display names independent of name binding.
- Add local-overlay annotations and update a control-flow test expectation.
| File | Description |
|---|---|
unified/ql/test/library-tests/controlflow/basicblock-slices.expected |
Reflect updated enum-constructor naming. |
unified/ql/lib/utils/test/TestUtils.qll |
Use shared qualified names for test aliases. |
unified/ql/lib/codeql/unified/internal/typeinference/TypeInference.qll |
Infer super through semantic parent classes. |
unified/ql/lib/codeql/unified/internal/NameBindingPluginSwift.qll |
Declare local-overlay support for Swift binding rules. |
unified/ql/lib/codeql/unified/internal/NameBindingPlugin.qll |
Declare local-overlay support for binding hooks. |
unified/ql/lib/codeql/unified/internal/mad/LegacyMaD.qll |
Include extension methods in legacy model matching. |
unified/ql/lib/codeql/unified/internal/FacadeAst.qll |
Add extension-aware navigation and separate semantic and display naming. |
Review effort: Max
hvitved
force-pushed
the
unified/extensions-convenience
branch
from
October 22, 2026 08:38
1d10583 to
590903d
Compare
asgerf
reviewed
Oct 22, 2026
asgerf
reviewed
Oct 22, 2026
asgerf
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
getAMemberIncludingExtensionsandgetParentClassfor takingextensions into account.