Repository navigation
Unified: Instantiate and expose public SSA api. - #22869
Draft
aschackmull wants to merge 1 commit into
Draft
aschackmull wants to merge 1 commit into
aschackmull wants to merge 1 commit into
Conversation
aschackmull
added
the
no-change-note-required
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aschackmull
force-pushed
the
unified/ssa-public
branch
from
October 22, 2026 08:11
abc70f6 to
1d6d86b
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved compilation and SSA mapping issues prevent reliable use of the new public API.
3 open issues
What changed in this PR
Exposes Unified’s default static single assignment (SSA) hierarchy for future libraries such as Guards.
Changes:
- Instantiate public SSA classes using Unified expressions, parameters, and variable writes.
- Export the
SsaAPI throughunified.qll. - Add expression accessors for control-flow nodes and basic blocks.
| File | Description |
|---|---|
unified/ql/lib/unified.qll |
Exports the public SSA API. |
unified/ql/lib/codeql/unified/internal/FacadeAst.qll |
Adds expression control-flow and basic-block accessors. |
unified/ql/lib/codeql/unified/internal/dataflow/LocalSsa.qll |
Implements the public SSA adapter and instantiates its hierarchy. |
Review effort: Max
| } | ||
|
|
||
| module SsaPublic { | ||
| module Ssa = MakeSsa<SsaInput>; |
| } | ||
|
|
||
| module SsaPublic { | ||
| module Ssa = MakeSsa<SsaInput>; |
Comment on lines
+56
to
+58
| exists(VariableDeclaration decl | | ||
| writeAccess = decl.getPattern() and result = decl.getValue() | ||
| ) |
aschackmull
marked this pull request as draft
October 22, 2026 10:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the default hierarchy of SSA classes, which will be needed by subsequent instantiations of other libraries (Guards, etc.)