Repository navigation
JavaScript: remove SEMMLE_TYPESCRIPT_HOME support - #22870
Merged
Merged
Conversation
paldepind
force-pushed
the
js/typescript-home
branch
from
October 22, 2026 08:41
04dd25c to
4591711
Compare
Co-authored-by: Copilot <[email protected]> Copilot-Session: b58bba12-96d2-40c2-aaf4-d249623a385c
paldepind
force-pushed
the
js/typescript-home
branch
from
October 22, 2026 08:46
4591711 to
c8c7820
Compare
paldepind
marked this pull request as ready for review
October 22, 2026 08:46
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Removing the compiler override is an intentional compatibility break that needs maintainer sign-off.
No open issues 🎉
What changed in this PR
Removes SEMMLE_TYPESCRIPT_HOME support so the JavaScript/TypeScript extractor consistently uses its bundled TypeScript compiler.
Changes:
- Switches both compiler consumers to direct
typescriptimports. - Deletes the override wrapper and its declaration file.
- Documents the compatibility break in a change note.
| File | Description |
|---|---|
javascript/ql/lib/change-notes/2026-10-22-remove-typescript-home.md |
Documents removal of the compiler override. |
javascript/extractor/lib/typescript/src/typescript.js |
Deletes the environment-dependent compiler wrapper. |
javascript/extractor/lib/typescript/src/typescript.d.ts |
Deletes the wrapper’s type declaration. |
javascript/extractor/lib/typescript/src/main.ts |
Imports TypeScript directly. |
javascript/extractor/lib/typescript/src/ast_extractor.ts |
Imports TypeScript directly. |
Review effort: Max
asgerf
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove support for overriding the TypeScript compiler with
SEMMLE_TYPESCRIPT_HOME. The JavaScript/TypeScript extractor now always uses its bundled TypeScript compiler.Here's my rationale, copy/pasted from a Slack thread:
SEMMLE_TYPESCRIPT_HOMEthen the 7.1 upgrade will be smoother for users. If anyone rely on it then the upgrade will go from breaking for their setup (requiring them to update to 7.1) into not breaking their setup (but ignoring an envvar they've set, if we don't want to do this silently we could log a warning).