Repository navigation
Conversation
The extractor ran `git config --global http.sslCAInfo <temp cert>` when private `git_source` registries were configured. That permanently modified the user's global git configuration, and on non-ephemeral (e.g. self-hosted) runners it kept pointing at a temporary certificate file after the job finished, breaking later git HTTPS operations. Instead, set `GIT_SSL_CAINFO` alongside `SSL_CERT_FILE` in the environment that `ApplyProxyEnvVars` applies to `go` commands. This is picked up by the `git` processes `go` spawns, and is scoped to those subprocesses. Co-authored-by: Copilot <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go extractor currently runs
git config --global http.sslCAInfo <temp cert>when privategit_sourceregistries are configured. This persists beyond the job: on non-ephemeral self-hosted runners, later jobs find git pointing at a temporary certificate that no longer exists.This PR removes that call and instead passes the certificate via
GIT_SSL_CAINFOin the environment applied togocommands (next toSSL_CERT_FILE), so it only affects thegitprocesses spawned bygo.Caveat:
gitinvoked outsideApplyProxyEnvVarsno longer gets the certificate; I haven't found such callers.Adds a unit test that
getEnvVarsreturns both variables.go test ./registriespasses.