Repository navigation
C#: Add some more logging to the Dependency Manager. - #22889
Open
michaelnebel wants to merge 3 commits into
Open
michaelnebel wants to merge 3 commits into
michaelnebel wants to merge 3 commits into
Conversation
…e and log non-excluded candidates as debug info.
michaelnebel
force-pushed
the
csharp/moredepmanlogging
branch
from
October 27, 2026 13:34
5c9dbb5 to
78e0762
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Dependency-selection logic is unchanged, and the remaining log-wording suggestions are non-blocking.
2 open issues
What changed in this PR
Adds diagnostics to the C# extractor’s Dependency Manager to make dependency discovery easier to troubleshoot.
Changes:
- Always log the legacy NuGet restore count, plus candidate DLL totals and debug-level paths.
- Log file-scan completion and detected project and framework features.
| File | Description |
|---|---|
| csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs | Logs restore counts and candidate DLL details. |
| csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FileContent.cs | Logs scan completion and detected features. |
Review effort: Max
michaelnebel
force-pushed
the
csharp/moredepmanlogging
branch
from
October 28, 2026 07:42
6873583 to
cb5a682
Compare
michaelnebel
added
the
no-change-note-required
michaelnebel
marked this pull request as ready for review
October 28, 2026 08:16
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding some more logging information that can help debug reported issues based on the logs.
DCA looks good.