Skip to content

Clarify where the "Make a contribution" button leads in CONTRIBUTING.md - #46412

Merged
janiceilene merged 2 commits into
github:mainfrom
nickpdean:claude/contributing-make-a-contribution-link
Oct 23, 2026
Merged

janiceilene merged 2 commits into
github:mainfrom
nickpdean:claude/contributing-make-a-contribution-link

Conversation

@nickpdean

Copy link
Copy Markdown
Contributor

Why:

Closes: n/a, no existing issue

.github/CONTRIBUTING.md says to click Make a contribution at the bottom of any docs page to make small changes in the UI. The button (src/frame/components/page-footer/Contribution.tsx) links to the article's source file at github.com/github/docs/blob/main/content/..., not to an editor, so a first-time contributor lands on a read-only file view with no hint about the next step.

What's being changed:

Explains that the button opens the source file, that you click the pencil icon to edit it, and that GitHub then asks you to fork and propose the change as a pull request. Links to Editing files in another user's repository, the article that already documents this flow.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

🤖 Generated with Claude Code

The button links to the article's source file on GitHub, not an editor.
Explain the pencil-and-fork step and link to the article on editing files
in another user's repository.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01AugnFjhMJiq9sxScLYogcu
Co-authored-by: nicholas.dean <[email protected]>
@welcome

welcome Bot commented Oct 22, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

This pull request contains code changes, so we will not generate a table of review links.

🤖 This comment is automatically generated.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Oct 22, 2026
@docs-bot docs-bot added the invalid This issue/PR is invalid label Oct 22, 2026
@docs-bot

Copy link
Copy Markdown
Collaborator

👋 Hi there! It looks like you've modified some files that we can't accept as contributions:

  • .github/CONTRIBUTING.md

You'll need to raise a new PR that doesn't include those files, before we can review.

The complete list of files we can't accept are:

  • Anything in the root directory
  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • .vscode/**
  • config/**
  • contributing/**
  • src/**
  • content/actions/how-tos/secure-your-work/security-harden-deployments/**
  • content/README.md

We also can't accept contributions to files in the content directory with frontmatter contentType: rai. You can always check out our full contribution guidelines.

@github-actions github-actions Bot closed this Oct 22, 2026
@janiceilene janiceilene added the skip-spammy-check Do not close legitimate PRs if they have triggered spam filters label Oct 23, 2026
@docs-bot docs-bot reopened this Oct 23, 2026
@docs-bot docs-bot removed the invalid This issue/PR is invalid label Oct 23, 2026
@docs-bot

Copy link
Copy Markdown
Collaborator

The skip-spammy-check label was added, so I removed the invalid label and reopened this pull request. The spammy pull request check skips it while the label is applied.

@docs-bot docs-bot added the invalid This issue/PR is invalid label Oct 23, 2026
@docs-bot

Copy link
Copy Markdown
Collaborator

👋 Hi there! It looks like you've modified some files that we can't accept as contributions:

  • .github/CONTRIBUTING.md

You'll need to raise a new PR that doesn't include those files, before we can review.

The complete list of files we can't accept are:

  • Anything in the root directory
  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • .vscode/**
  • config/**
  • contributing/**
  • src/**
  • content/actions/how-tos/secure-your-work/security-harden-deployments/**
  • content/README.md

We also can't accept contributions to files in the content directory with frontmatter contentType: rai. You can always check out our full contribution guidelines.

@github-actions github-actions Bot closed this Oct 23, 2026
@subatoi subatoi added skip-unallowed-check skip-spammy-check Do not close legitimate PRs if they have triggered spam filters and removed skip-spammy-check Do not close legitimate PRs if they have triggered spam filters labels Oct 23, 2026
@docs-bot docs-bot reopened this Oct 23, 2026
@docs-bot docs-bot removed the invalid This issue/PR is invalid label Oct 23, 2026
@docs-bot

Copy link
Copy Markdown
Collaborator

The skip-spammy-check label was added, so I removed the invalid label and reopened this pull request. The spammy pull request check skips it while the label is applied.

@janiceilene janiceilene left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution and apologies for all the bot arguing we were doing! I'll get this merged ⚡

@janiceilene
janiceilene added this pull request to the merge queue Oct 23, 2026
Merged via the queue into github:main with commit 205d63d Oct 23, 2026
48 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-spammy-check Do not close legitimate PRs if they have triggered spam filters skip-unallowed-check triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants