Repository navigation
fix(http): preserve repeated request configuration headers - #3625
Open
as992949791 wants to merge 1 commit into
Open
as992949791 wants to merge 1 commit into
as992949791 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve all field lines for list-valued request configuration headers. Requests with two
X-MCP-Toolsetsfield lines now behave like the equivalent comma-separated field.Why
Header.Getdiscarded names from laterX-MCP-Toolsets,X-MCP-Tools,X-MCP-Exclude-Tools, andX-MCP-Featuresfield lines. This could hide requested tools or omit configured exclusions/features when a client or intermediary supplied more than one line.Fixes #3624.
What changed
MCP impact
Prompts tested (tool changes only)
Not applicable. Tested the middleware through HTTP requests without calling tools or live APIs.
Security / limits
Tool renaming
Lint & tests
./script/lint(golangci-lint v2.14.0 built with Go 1.27.3)./script/test(go test -race ./...)go vet ./pkg/http/middlewareandgit diff --checkpassed.Evidence
TestWithRequestConfigRepeatedListHeadersfailed for toolsets, tools, excluded tools, and features: expected[first second third fourth], got[first second].Docs
Merge Danger
Door: two-way. Blast Radius: request configuration.
Prepared with AI assistance (Codex). All listed checks were executed locally.