Repository navigation
feat(canvas): request repository feedback reviews - #68
Open
lukasoppermann wants to merge 12 commits into
Open
lukasoppermann wants to merge 12 commits into
lukasoppermann wants to merge 12 commits into
Conversation
Add a right-aligned More actions menu with Improve context and Storybook examples for the toolbar and full canvas. Keep the live action hidden until backend authorization and skill dispatch are connected. Co-authored-by: Copilot App <[email protected]> Copilot-Session: f40ecac0-5eee-4e26-b3b0-f65abdba3749
There was a problem hiding this comment.
🔵 Needs a closer look
The Enter handler needs correction, and browser activation, focus restoration, and menu layout remain unverified.
1 open issue
What changed in this PR
Previews a More actions menu for occasional prototype-canvas actions while keeping it hidden in the live canvas.
Changes:
- Adds a callback-gated Improve context item after Publish and Share.
- Adds closed/open Storybook examples and tests for visibility, activation, and focus.
- Documents the preview-only scope and refreshes bundled labels.
| File | Description |
|---|---|
hub/docs/storybook.md |
Documents the preview stories and deferred workflow. |
hub/app/javascript/utils/prototype-canvas/en.ts |
Adds menu and action labels. |
hub/app/javascript/components/prototype-canvas-toolbar/styles.css |
Adds menu-item spacing. |
hub/app/javascript/components/prototype-canvas-toolbar/stories.tsx |
Adds isolated toolbar menu examples. |
hub/app/javascript/components/prototype-canvas-toolbar/index.tsx |
Adds the conditional actions menu and activation handlers. |
hub/app/javascript/components/prototype-canvas-toolbar/index.test.tsx |
Covers visibility, ordering, activation, and focus. |
hub/app/javascript/application/prototype-canvas/stories.tsx |
Adds full-canvas examples with Storybook-only callbacks. |
hub/app/javascript/application/prototype-canvas/index.tsx |
Passes the optional callback to the toolbar. |
.github/extensions/replica-prototype/assets/canvas-bridge.js |
Refreshes bundled canvas labels. |
Review effort: Max
Prevent the menu trigger from reopening after Enter and assert cancellation and restored focus. Rebuild Controls consumers of the shared canvas copy so their freshness checks match the new labels. Co-authored-by: Copilot App <[email protected]> Copilot-Session: f40ecac0-5eee-4e26-b3b0-f65abdba3749
Describe how the skill improves repository context from user feedback on hover and keyboard focus, with matching tests and rebuilt assets. Co-authored-by: Copilot App <[email protected]> Copilot-Session: f40ecac0-5eee-4e26-b3b0-f65abdba3749
Connect Improve context to fresh Hub authorization and the bundled feedback-review skill. Preserve the review-only boundary and bump the plugin to 1.5.0. Co-authored-by: Copilot App <[email protected]> Copilot-Session: f40ecac0-5eee-4e26-b3b0-f65abdba3749
lukasoppermann
changed the title
Preserve the updated Storybook catalogue and copy the complete review skill with its handoff reference so merge builds remain fresh. Co-authored-by: Copilot App <[email protected]> Copilot-Session: f40ecac0-5eee-4e26-b3b0-f65abdba3749
lukasoppermann
changed the title
Remove the maintainer-only restriction while retaining fresh Hub repository access checks and connection guards. Co-authored-by: Copilot App <[email protected]> Copilot-Session: f40ecac0-5eee-4e26-b3b0-f65abdba3749
Reuse the existing Hub connection and repository-access APIs to request the review skill without new Rails endpoints or capability fields. Co-authored-by: Copilot App <[email protected]> Copilot-Session: f40ecac0-5eee-4e26-b3b0-f65abdba3749
Restore the requested tooltip, remove the automatic success message, and require agreement before adding Hub or canvas feedback messages. Co-authored-by: Copilot App <[email protected]> Copilot-Session: f40ecac0-5eee-4e26-b3b0-f65abdba3749
Regenerate the canvas and Controls assets from the merged source. Co-authored-by: Copilot App <[email protected]> Copilot-Session: f40ecac0-5eee-4e26-b3b0-f65abdba3749
Preserve both toolbar flows and packaged skills, and regenerate shared bundles from merged source. Co-authored-by: Copilot App <[email protected]> Copilot-Session: f40ecac0-5eee-4e26-b3b0-f65abdba3749
Keep feedback review dispatch and stale-context checks in the typed server source and regenerate its runtime. Co-authored-by: Copilot App <[email protected]> Copilot-Session: f40ecac0-5eee-4e26-b3b0-f65abdba3749
Co-authored-by: Copilot App <[email protected]> Copilot-Session: f40ecac0-5eee-4e26-b3b0-f65abdba3749
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
People working in a prototype repository need a way to review user feedback from the canvas without adding another full-width toolbar button. The action uses the connected Hub user's repository access, not the local GitHub CLI account or Hub administrator role.
What changes
Adds a three-dot More actions menu after Publish and Share. Its Improve context item is available to every connected user with repository access, including Read and Triage as well as Write, Maintain and Admin. No maintainer role is required. The extension verifies the existing Hub connection again on click; changed repositories, branches, connections or Hub selections prevent dispatch. Disconnected users and users without verified repository access do not see the item.
Clicking requests the bundled
/review-hub-feedbackskill in the current chat. The skill identifies reusable themes and asks for a judge model and reasoning when needed. Solution generation and repository context edits are not part of this action. The canonical skill offers a separately requested proposal handoff, but the proposal skill is not bundled here. The toolbar shows request progress and errors, and overlapping clicks send one request.This is a canvas/plugin change with no Rails backend changes or required Hub deployment. It reuses
GET /api/canvas/connectionand the existing feedback APIs; Hub's normal read-access caching applies. The canvas UI source remains underhub/app/javascript/because it shares Hub's frontend layers, then builds into the extension assets. The plugin bundles the existing starter review skill and its supporting references, moves to version 1.5.0, and adds repository-maintainer guidance to ask for a patch or minor bump once per canvas-changing PR. Storybook includes isolated toolbar and full-canvas examples with the menu closed and open.A deployed, signed-in Hub-to-Copilot skill run remains unverified.
Storybook screenshots
Prototype canvas/Publication example — More Actions Open (light; viewport dimensions were not recorded). This fixture screenshot predates the catalogue rename; removing the backend dependency does not change the menu's appearance.
Screenshot coverage remains incomplete for Prototype canvas/Publication example — Improve Context and Prototype canvas/Toolbar — Improve Context and More Actions Open; those individual captures are not attached.