Repository navigation
test: fail on act warnings and keep one render per test - #3501
Merged
Merged
Conversation
Add a setup that fails a test when React reports an update outside act, after flushing queued work and unmount cleanup. Split the AccountHeader collapsed/expanded assertion into two independent tests.
setchy
force-pushed
the
test/act-warning-gate
branch
from
October 25, 2026 13:34
e4f848c to
4148345
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
act(...)warning.AccountHeader“labels the toggle by collapsed state” test into two independent tests (expanded and collapsed).Why
Act warnings are test bugs (a store update or promise resolving outside
act) but were only visible in logs. The gate makes them fail where they happen. The split removes the last in-test remount pattern; each test now owns its render.Verification
pnpm test: 200 files, 1,968 tests passedpnpm exec vp check --no-fmt: 464 files passed