Repository navigation
test: replace route snapshots with structure assertions - #3502
Merged
Merged
Conversation
setchy
force-pushed
the
test/route-snapshot-strategy
branch
2 times, most recently
from
October 25, 2026 13:39
14d9b0a to
f658252
Compare
Drop the full-tree Settings and Filters route snapshots. Assert the complete settings heading outline and every visible setting label grouped by section, plus every filter option, account, search control, and footer action. Scope filter checkbox names and ids to their section so repeated labels such as Other resolve to the right control.
setchy
force-pushed
the
test/route-snapshot-strategy
branch
from
October 25, 2026 13:44
f658252 to
74466be
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Settingsroute snapshot (5.1k lines) with the complete heading outline (sections plus Fetch/List/GitHub subheadings) and an assertion for every visible setting label, grouped by section.Filtersroute snapshot (3.5k lines) with an assertion for every filter option in each section (counting duplicate labels), every account checkbox, both search inputs, and the clear-filters action.Otherresolve to the right control..snapfiles.Why
These snapshots duplicated the visual regression suite and changed on every markup adjustment, making reviews noisy and rebases conflict-prone. Visual regression remains the pixel-level guard; the unit tests now describe the route contract.
Verification
pnpm test: 200 files, 1,967 tests passedpnpm exec vp check --no-fmt: 464 files passedscripts/visual.shbaselines unchanged