Repository navigation
Conversation
Collaborator
|
This looks like a duplicate of #4657, right? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4658 +/- ##
==========================================
- Coverage 98.63% 98.62% -0.01%
==========================================
Files 201 201
Lines 18867 18874 +7
==========================================
+ Hits 18609 18615 +6
- Misses 258 259 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
You are right, #4657 covers this. Closing this PR as a duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the primary rate-limit retry path so it replays the request body instead of
sending the already consumed body. If the request has a body that cannot be
replayed (
GetBodyis nil), the retry is skipped and the rate limit error isreturned.
Changes
req.Bodyfromreq.GetBody()before retrying inbareDo.GetBodyis nil.full JSON body, plus a test for the non-replayable body case.
Tests
go test ./github/ -run "RateLimit|Retry" -count=1go test ./github/ -count=1go test ./... -count=1in theotelmoduleAI assistance: drafted with an AI coding agent and reviewed before submission.
Fixes #4656