Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request fixes a potential TypeError in the positional_wrapper helper function when a decorated function has no default arguments, causing inspect.getfullargspec to return None for defaults. The calculation has been updated to use an empty tuple as a fallback, and corresponding unit tests have been added to verify this behavior. I have no feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
TypeError: object of type 'NoneType' has no len()when decorating functions without default arguments using@_helpers.positionalas a bare decorator.Problem
In
googleapiclient/_helpers.py,positional()automatically calculates the maximum positional arguments when used without arguments:When a function does not define default arguments (e.g.,
def func(a, b): ...ordef func(): ...),inspect.getfullargspec(...).defaultsevaluates toNone. Evaluatinglen(defaults)then crashes with:TypeError: object of type 'NoneType' has no len()Solution
Safely fallback to an empty tuple when
defaultsisNonevialen(defaults or ()). This correctly computeslen(args) - 0 = len(args)positional arguments without raising aTypeError.Testing
tests/test__helpers.pyverifying@_helpers.positionalon functions without default parameters and functions without arguments.pytest tests/test__helpers.pyacross default andPOSITIONAL_EXCEPTIONenforcement modes; all passed.Related Issue
Closes #2845