Repository navigation
feat(storage): add support for DirectPath over Interconnect - #14006
Open
nidhiii-27 wants to merge 20 commits into
Open
nidhiii-27 wants to merge 20 commits into
nidhiii-27 wants to merge 20 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for DirectPath xDS over Interconnect (on-premise xDS name resolution) in GrpcStorageOptions and InstantiatingGrpcChannelProvider, allowing GCE environment checks to be bypassed when enabled. It also updates endpoint validation to support custom URI schemes like google-c2p:/// and adds corresponding tests. The reviewer suggests dynamically adjusting the log level for the DirectPath fallback warning to avoid excessive warning spam in non-GCE environments, recommending Level.WARNING on GCE and Level.FINE elsewhere.
nidhiii-27
marked this pull request as ready for review
August 6, 2026 08:45
kalragauri
reviewed
Aug 27, 2026
ShreyasSinha
requested changes
Sep 2, 2026
nidhiii-27
force-pushed
the
add-dp-over-gci
branch
from
September 4, 2026 08:45
6b73da7 to
d2bdc4a
Compare
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
nidhiii-27
force-pushed
the
add-dp-over-gci
branch
from
September 4, 2026 08:48
d2bdc4a to
21b3acf
Compare
nidhiii-27
force-pushed
the
add-dp-over-gci
branch
from
September 4, 2026 08:57
21b3acf to
fb844cb
Compare
[Generated-by: AI]
fix spanner tests failing due to overridden authority for default builder branch [Generated-by: AI]
kalragauri
reviewed
Sep 4, 2026
…nect - Generalize DirectPath over Interconnect host and authority handling in InstantiatingGrpcChannelProvider for any service using -direct. convention - Rethrow RuntimeException in extractTargetFromChannelBuilder to surface reflection errors in CI - Remove unused DEFAULT_HOST_DIRECT_PATH constant in GrpcStorageOptions - Add generic non-GCS unit tests in InstantiatingGrpcChannelProviderTest [Generated-by: AI]
- Define DIRECT_PATH_INTERCONNECT_INFIX constant to eliminate duplicated "-direct." string literals - Add explanatory comment in empty catch block of extractAuthorityFromChannelBuilder [Generated-by: AI]
…on in tests - Remove unintended positive test filter from Surefire plugin configuration in gax-grpc/pom.xml, allowing all standard unit tests in InstantiatingGrpcChannelProviderTest to run and restore code coverage. - Inspect authorityOverride field and unwrap builder delegates in InstantiatingGrpcChannelProviderTest#extractAuthorityFromChannelBuilder. [Generated-by: AI]
Replace 4 duplicate invalid endpoint tests with a single parameterized test to address SonarCloud java:S5976. [Generated-by: AI]
kalragauri
approved these changes
Sep 7, 2026
Address review feedback on RFC query/fragment delimiter support, reflection cleanup with Mockito, and dynamic guard documentation. [Generated-by: AI]
ShreyasSinha
approved these changes
Sep 11, 2026
blakeli0
reviewed
Oct 5, 2026
[Generated-by: AI]
Run fmt-maven-plugin:format to resolve CI lint failure. [Generated-by: AI]
…ver Interconnect [Generated-by: AI]
blakeli0
reviewed
Oct 15, 2026
nidhiii-27
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
blakeli0
reviewed
Oct 21, 2026
…AX and retain -direct authority Merge origin/main, move the -direct. host rewrite into InstantiatingGrpcChannelProvider, remove overrideAuthority so GoogleCloudToProdNameResolver retains the -direct authority, and remove the obsolete :/// check in validateEndpoint. [Generated-by: AI]
|
|
kalragauri
approved these changes
Oct 23, 2026
kalragauri
left a comment
kalragauri
left a comment
There was a problem hiding this comment.
nit: the last bullet in the description is out of date after the latest commit. The host rewrite now lives in GAX (rewriteDirectPathInterconnectHost) and the channel no longer overrides the authority to storage.googleapis.com.
| ManagedChannelBuilder<?> channelBuilder = provider.createChannelBuilder(); | ||
| Truth.assertThat(extractTargetFromChannelBuilder(channelBuilder)) | ||
| .isEqualTo("google-c2p:///storage-direct.googleapis.com?force-xds"); | ||
| Truth.assertThat(extractAuthorityFromChannelBuilder(channelBuilder)).isNull(); |
There was a problem hiding this comment.
The test names still describe the earlier behavior: the tests assert that no authority override is set and that the resolver derives the -direct authority.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
google-c2p:///<service>?force-xdstarget scheme.:///syntax (e.g.google-c2p:///).storage-direct.googleapis.comand override the request authority to storage.googleapis.com for secure TLS handshakes.