Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
386ec37 to
c72e920
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request implements session resumption for resumable uploads in the Java GAX library. It introduces the resumeCall method in ResumableUploadCallableImpl, updates ResumableUploadFutureImpl and ResumableUploadProgressTracker to handle resumption, and enhances RewindableStreamBuffer to skip forward to the server's committed offset. Comprehensive unit and integration tests are also added. Feedback suggests preserving the original EOFException as the cause when catching it from ByteStreams.skipFully in RewindableStreamBuffer to maintain the exception chain and avoid potential null messages.
c72e920 to
cf0c9d4
Compare
cf0c9d4 to
c6f9b2b
Compare
c6f9b2b to
b02ed8c
Compare
|
|
This branch has not been deployed
1 participant
Implements
ResumableUploadCallable.resumeCall(...)to support resuming interrupted resumable upload sessions from a saved session URL and effective chunk size.