Repository navigation
Conversation
whowes
added this pull request to stack #14732
October 22, 2026 16:41
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the resumable upload logic by extracting helper methods such as 'setUpGlobalTimeout' and 'createAndRegisterCoordinator' in 'ResumableUploadFutureImpl', and passing 'ResumableUploadProgressTracker' via dependency injection. A potential thread-safety issue was identified in 'createAndRegisterCoordinator' where calling 'checkNotNull(payload)' before checking if 'inFlightFuture == null' could lead to a 'NullPointerException' during concurrent cancellation.
whowes
changed the title
whowes
marked this pull request as ready for review
October 22, 2026 17:30
blakeli0
approved these changes
Oct 22, 2026
whowes
force-pushed
the
whowes/resumable-upload-refactor
branch
from
October 22, 2026 21:58
92c7755 to
f705156
Compare
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The helpers extracted from the end-to-end upload path will be used in resumed uploads in the next PR
Also of note:
ResumableUploadProgressTrackerconstructor now accepts an initial status so resumed uploads can initialize the tracker directly inSTATE_RECOVERINGrather thanSTATE_STARTING.