Repository navigation
fix(bigquery-jdbc): fix missing logger instances - #14733
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors logger instantiation across several classes, including BigQueryJdbcBulkInsertWriter, BigQueryParameterHandler, BigQueryPreparedStatement, and BigQueryResultSetMetadata, by changing the LOG field from an instance variable to a static final variable. This change prevents the redundant registration of child loggers on the driver root logger for every new object instance. Additionally, unit tests have been added to BigQueryJdbcCustomLoggerTest to verify that creating multiple instances of these classes does not leak or register additional child loggers. There are no review comments, and I have no further feedback to provide.
keshavdandeva
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More instances of per-class logger instances, follow up for #14716