Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces OpenTelemetry tracing attributes to track the fast open configuration and cache status for Bidirectional Read (Bidi) sessions in Google Cloud Storage. Specifically, it adds the "gcs.bidi.fast_open" attribute to the "blobReadSession" span and the "gcs.bidi.cache_status" attribute (with values "HIT" or "MISS") to the "readAs" spans. Corresponding integration tests have been added to verify these tracing behaviors. I have no feedback to provide on these changes.
Dhriti07
force-pushed
the
fast-open/07-public-api
branch
from
October 31, 2026 18:48
7c4262e to
63fb3c4
Compare
Dhriti07
force-pushed
the
fast-open/08-tracing-attributes
branch
from
October 31, 2026 18:48
e740d72 to
540e2ca
Compare
Eighth step of fast open BiDi reads (go/fast-open-bidi-read, b/552263062). With fast open, the blobReadSession span also covers reading the first range, and a readAs served from the fast open read takes ~0 ms with no request. Add span attributes so traces explain this: - gcs.bidi.fast_open (true/false) on the blobReadSession span: whether a read was sent with the open. - gcs.bidi.cache_status (HIT/MISS) on each readAs span of a session opened with fast open: HIT when the readAs was served from the fast open read, MISS when it sent a new read. Sessions without fast open don't get it.
Dhriti07
force-pushed
the
fast-open/07-public-api
branch
from
November 1, 2026 12:01
63fb3c4 to
d14e2a9
Compare
Dhriti07
force-pushed
the
fast-open/08-tracing-attributes
branch
from
November 1, 2026 12:01
540e2ca to
6bd1b9a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8/n of fast open BiDi reads.
With fast open, the blobReadSession span also covers reading the first range, and a readAs served from the fast open read takes ~0 ms with no request. Add span attributes so traces explain this: