[Dhriti07]

9/n of fast open BiDi reads

ITFastOpenTest runs fast open against a zonal bucket on production:

• byte array, ByteString and channel reads; the byte array test also checks with tracing that readAs was served from the open (cache_status HIT)
• a 16 MiB read that arrives in many responses
• more reads on the same session
• a read starting exactly at the end of the object (empty)
• a read past the end of the object
• an object that doesn't exist (404) and a failed precondition (412)
• closing the session without claiming the fast open read

[gemini-code-assist]

Code Review

This pull request introduces a new integration test class, ITFastOpenTest, to verify the fast open read functionality for Google Cloud Storage under various scenarios, including partial reads, large objects, and error conditions. The feedback recommends managing the OpenTelemetrySdk instance inside a try-with-resources block in the bytes_areServedFromTheOpen test to ensure it is properly closed and to prevent potential resource leaks.

[gemini-code-assist]

The OpenTelemetrySdk instance is not closed after the test finishes. Since OpenTelemetrySdk implements AutoCloseable, it should be managed within a try-with-resources block to ensure that its tracer provider and associated span processors are properly shut down and do not leak resources (such as threads or memory) between test runs.

Suggested change

	OpenTelemetrySdk.builder()
	.setTracerProvider(
	SdkTracerProvider.builder()
	.addSpanProcessor(SimpleSpanProcessor.create(exporter))
	.build())
	.build();
	try (Storage traced =
	storage.getOptions().toBuilder().setOpenTelemetry(otel).build().getService();
	BlobReadSession session = traced.blobReadSession(blobId, READ_10_TO_20).get(30, SECONDS)) {
	byte[] actual = session.readAs(READ_10_TO_20).get(30, SECONDS);
	try (OpenTelemetrySdk otel =
	OpenTelemetrySdk.builder()
	.setTracerProvider(
	SdkTracerProvider.builder()
	.addSpanProcessor(SimpleSpanProcessor.create(exporter))
	.build())
	.build();
	Storage traced =
	storage.getOptions().toBuilder().setOpenTelemetry(otel).build().getService();
	BlobReadSession session = traced.blobReadSession(blobId, READ_10_TO_20).get(30, SECONDS)) {

References

1. Use try-with-resources to manage closeable resources in tests to ensure they are safely closed and prevent resource leaks.