Repository navigation
fix(motd): match precise native alignment to the shared viewer - #113
Merged
Merged
Conversation
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Proxy centering used regular-space-only padding and excluded the native bold-space advance from text measurement. Its output could differ from the shared editor/viewer and visibly misalign two centered lines.
Change
After resolving runtime values, choose the closest non-overflowing combination of regular 4-pixel and bold 5-pixel spaces. Use the same tie-breaking and fixtures as library-motd#142; keep existing modern/legacy widths. Prefix styles do not leak into the actual message. Cached templates and network-wide player/region context remain unchanged, with no I/O on the ping path.
Validation
All 200 Velocity tests pass, including production multi-proxy handler coverage. Added byte-identical shared alignment fixtures and an independent exhaustive check for remaining widths 0–280, covering short/right-aligned lines and explicit normal-text style after bold padding. Spotless passes with stale build/configuration caches disabled.
Closes #112. Related library change: groundsgg/library-motd#142.