Repository navigation
Conversation
The skip list ("USERNAME", "SJLOG", "COMMAND", "RM") was matched as a
substring, so e.g. a parameter "fusion_format" (contains "RM") was not
saved. Match the whole name (case insensitive), as documented.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the parameter-name matching fix.
No open issues 🎉
What changed in this PR
Fixes save_script_parameters so the case-insensitive skip list matches whole parameter names, preventing ordinary parameters such as fusion_format from being omitted.
Changes:
- Replaces substring matching with exact-name membership.
- Adds a regression test confirming
rmis skipped whilefusion_formatandcommanderare saved. - Documents the corrected behavior in the changelog.
| File | Description |
|---|---|
tests/test_misc.py |
Adds regression coverage for whole-name, case-insensitive skipping. |
src/imcflibs/imagej/misc.py |
Uses exact-name matching and clarifies the explanatory comment. |
CHANGELOG.md |
Records the parameter-saving fix. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #162 +/- ##
====================================
Coverage 33% 33%
====================================
Files 25 25
Lines 1806 1806
====================================
Hits 591 591
Misses 1215 1215 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ehrenfeu
self-requested a review
October 28, 2026 18:26
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
fix-save-script-parameters-skip, based ondevel(8482d1a).imcflibs.imagej.misc.save_script_parametersmatched its skip list (USERNAME,SJLOG,COMMAND,RM) as substrings of the parameter names, so ordinary parameters containing one of them weresilently left out of the saved file, e.g.
fusion_format(containsRM),format,normalize,firmware,informed, ... The docstring describes the list as runtime keys to skip (caseinsensitive), i.e. whole names.
Fix:
if key.upper() in skip_keys. New testtest_save_script_parameters_skip_whole_names(
rmskipped,fusion_formatandcommanderkept); it fails before the fix. All tests pass,ruff checkand markdownlint clean.