Repository navigation
Document side conversation, WhatsApp status and phone switch errors - #767
Merged
yasser-aboelgheit-intercom merged 1 commit intoOct 23, 2026
Merged
yasser-aboelgheit-intercom merged 1 commit into
yasser-aboelgheit-intercom merged 1 commit into
Conversation
Add the 400 side_conversation error to delete, attach contact, detach contact and convert to ticket. Give the WhatsApp status errors the error.list shape, and add the 403 to the WhatsApp message status endpoint. For phone call redirects, list the 422 error keys from phone number validation, describe the 400 as a failed phone number lookup or SMS send, and add the 401 returned when the workspace can't use the feature. Applies to 2.17 and Preview. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
markdennis22
approved these changes
Oct 23, 2026
markdennis22
left a comment
Contributor
There was a problem hiding this comment.
Thanks Yasser, the new and changed error examples match what the API returns.
I compared both files against main, checked the 2.17 and Preview edits are the same, ran fern check (no new errors or warnings), and checked each example against the API's behaviour. The only Preview SDK change is the four added error classes, and it's additive.
Approving.
~ Automated via Claude
yasser-aboelgheit-intercom
deleted the
yasser-aboelgheit-intercom/lane2-conv-errors
branch
October 23, 2026 15:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Deleting a conversation, attaching or detaching a contact, and converting a conversation to a ticket all return a
400with codeside_conversationwhen the ID is a side conversation, but the reference doesn't list it. The WhatsApp status errors were shown as{type: error, message}when the API returns anerror.list, and the WhatsApp message status endpoint can also return the403plan error. The phone call redirect errors showed a placeholder422key and didn't cover the401returned when the workspace can't use the feature.How?
Add the
side_conversation400example to the four conversation endpoints, give the WhatsApp status400and500examples theerror.listshape with their real codes, and add the403to the WhatsApp message status endpoint. ForPOST /phone_call_redirects, show the422keys from phone number validation (invalid_phone_number,landline_phone,twilio_settings), describe the400as a failed phone number lookup or SMS send, and add the feature401, in both 2.17 and Preview.Generated with Claude Code