Skip to content

Document side conversation, WhatsApp status and phone switch errors - #767

Merged
yasser-aboelgheit-intercom merged 1 commit into
mainfrom
yasser-aboelgheit-intercom/lane2-conv-errors
Oct 23, 2026
Merged

yasser-aboelgheit-intercom merged 1 commit into
mainfrom
yasser-aboelgheit-intercom/lane2-conv-errors

Conversation

@yasser-aboelgheit-intercom

Copy link
Copy Markdown
Contributor

Why?

Deleting a conversation, attaching or detaching a contact, and converting a conversation to a ticket all return a 400 with code side_conversation when the ID is a side conversation, but the reference doesn't list it. The WhatsApp status errors were shown as {type: error, message} when the API returns an error.list, and the WhatsApp message status endpoint can also return the 403 plan error. The phone call redirect errors showed a placeholder 422 key and didn't cover the 401 returned when the workspace can't use the feature.

How?

Add the side_conversation 400 example to the four conversation endpoints, give the WhatsApp status 400 and 500 examples the error.list shape with their real codes, and add the 403 to the WhatsApp message status endpoint. For POST /phone_call_redirects, show the 422 keys from phone number validation (invalid_phone_number, landline_phone, twilio_settings), describe the 400 as a failed phone number lookup or SMS send, and add the feature 401, in both 2.17 and Preview.

Generated with Claude Code

Add the 400 side_conversation error to delete, attach contact, detach
contact and convert to ticket. Give the WhatsApp status errors the
error.list shape, and add the 403 to the WhatsApp message status
endpoint. For phone call redirects, list the 422 error keys from phone
number validation, describe the 400 as a failed phone number lookup or
SMS send, and add the 401 returned when the workspace can't use the
feature. Applies to 2.17 and Preview.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

@markdennis22 markdennis22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yasser, the new and changed error examples match what the API returns.

I compared both files against main, checked the 2.17 and Preview edits are the same, ran fern check (no new errors or warnings), and checked each example against the API's behaviour. The only Preview SDK change is the four added error classes, and it's additive.

Approving.

~ Automated via Claude

@yasser-aboelgheit-intercom
yasser-aboelgheit-intercom merged commit 922cd4c into main Oct 23, 2026
4 checks passed
@yasser-aboelgheit-intercom
yasser-aboelgheit-intercom deleted the yasser-aboelgheit-intercom/lane2-conv-errors branch October 23, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants