Repository navigation
docs: align tutorial, quickstart, and testing pages with the updated starters - #4805
Open
brandyscarney wants to merge 5 commits into
Open
brandyscarney wants to merge 5 commits into
brandyscarney wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
added this pull request to stack #4807
October 23, 2026 20:14
This was referenced Oct 23, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Does
Updates the Angular, React, and Vue docs so their code matches what
ionic startnow generates and what the "Your First App" tutorial repos contain. The starters and tutorial apps now lint with@ionic/eslint-config, format with@ionic/prettier-config, and run end-to-end tests with Playwright instead of Cypress.New Behavior
Changes
import typefor type-only imports, and Prettier formatting.PhotoServiceandTab2Pagein Angular,usePhotoGalleryin React and Vue.Camera.getPhotooptions have inline comments explaining each one.IonGrid,IonRow, andIonColimports.import './Tab2.css'.deletePhoto()instead ofdeletePicture().photos.service.tsinstead ofphoto.service.ts.tabs.page.tsstep that registers theimagesicon. Without it, the Photos tab showed a blank icon after following the tutorial.Date.now()is nownew Date().getTime(), which passes the starter'sreact-hooks/purityrule. TheApp.tsxsnippet showssetupIonicReact().savePicture()passes the data fromFilesystem.readFile()straight toFilesystem.writeFile()asstring | Blob, like Angular, instead of converting a Blob with.text()(which would save raw bytes as base64).fetchlines in step 4. Step 7 keys photos by file path, like step 2, instead of switching to the index.eslint.config.jsand the current starter files.test/expectfromvitest, since the starter doesn't enable globals.src/setupTests.tsnow imports@testing-library/jest-dom/vitestinstead ofextend-expect, which jest-dom 6 removed.user-eventhas its own install step, since starters don't include it.vue/no-deprecated-slot-attributetip now useseslint.config.js.import type { RouteRecordRaw }andRouteRecordRaw[], matching the quickstart.Related PRs
Starters (merge before this PR):
Tutorial apps (each a stack of five PRs: lint and Prettier, lint fixes, test infrastructure, test coverage, matching the docs):
Notes
versioned_docs.