Skip to content

test(button): add missing coverage and consolidate snapshots - #31627

Draft
thetaPC wants to merge 9 commits into
ionic-modularfrom
FW-6838-tests
Draft

thetaPC wants to merge 9 commits into
ionic-modularfrom
FW-6838-tests

Conversation

@thetaPC

@thetaPC thetaPC commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Issue number: resolves internal


What is the current behavior?

Button's tests skip the ionic theme in several specs, take a separate screenshot for every variant, and never check the default shape, fill and size. In md, activated screenshots don't show the ripple, which only appears on a real press.

What is the new behavior?

No component code changes. This sets the baselines the button migration is compared against, so its snapshot diffs come only from the migration.

  • Adds spec tests for the default shape per theme, and the default fill and size inside parents such as ion-buttons and ion-item
  • Adds the ionic theme to the expand, icon, item buttons and toolbar colors specs, and runs the spinner spec in every theme
  • Adds the medium size to the size spec, alone and in ion-buttons, and a disabled button in each color to the basic, outline and clear pages
  • Consolidates the shape, states, size, strong, wrap, badge and a11y scale screenshots into one grid per spec
  • Test pages freeze the ripple on .ion-activated elements, and goto waits for it, so md activated screenshots show the pressed state. This also updates the activated snapshots of card, item, item-sliding, tab bar and toolbar
  • Skips the a11y check for a pressed outline button in md's dark palette (TODO(FW-6417)). Its text fails contrast once the ripple is visible, and that predates this PR

Does this introduce a breaking change?

  • Yes
  • No

Other information

The migration PR is stacked on this one.

@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-framework Ready Ready Preview Oct 26, 2026 10:17pm UTC

Request Review

@github-actions github-actions Bot added the package: core @ionic/core package label Oct 21, 2026
@thetaPC
thetaPC added this pull request to stack #31629 October 21, 2026 23:00

This branch was successfully deployed

1 active deployment
Preview — 6369c144 Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants