Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1580
In
Kernel.process_control,Kernel.dispatch_shell, andKernel.shell_channel_thread_main,self.session.feed_identities(msg, copy=False)was called immediately before thetry ... except Exception:block that wrapsself.session.deserialize(...)(whereasKernel.shell_mainalready wrapped both insidetry ... except Exception:).When a non-Jupyter connection or malformed message without the
<IDS|MSG>delimiter arrives on the shell or control port,feed_identitiesraisesValueError: DELIM not in msg_list. Becauseshell_channel_thread_mainanddispatch_controlare registered directly asZMQStream.on_recvcallbacks in ipykernel 7, the uncaughtValueErrorescaped intoZMQStream._log_error(tornado.general), printing the traceback into the active notebook cell'sstderroutput instead of logging it toself.log.Move
feed_identitiesinside the existingtry ... except Exception:blocks inprocess_control,dispatch_shell, andshell_channel_thread_mainso malformed messages missingDELIMare logged viaself.log.error(...)as in 6.x.