Repository navigation
CLI: Update Go SDK to 738369d524a3806832577f6793dde7eaf15c5725 - #304
kernel-internal[bot] wants to merge 8 commits into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
1f9ef54 to
8296665
Compare
save-profile now prints whether it created or overwrote the profile, and no longer lets the SDK retry: a retry after a failed or slow save starts a second save and restarts the browser again. The help text names browser_not_active, mentions Playwright connections, and says to save at a stable point.
hiroTamada
left a comment
There was a problem hiding this comment.
reviewed — the vault no-replay middleware is a real fix (verified both subtests fail with writes=2 without it), and the new surfaces look well-guarded. a couple of questions, neither blocking:
Questions
cmd/browsers.go:1109— save-profile restarts the browser but uses default SDK retries (2x on 409/5xx/conn errors). help says "retry only browser_busy", but the SDK will also auto-retry browser_lease_changed/inactive 409s. consideroption.WithMaxRetries(0)or confirm the API sendsx-should-retry: falsecmd/vaults_commands.go:498-537— does the API accept PATCH on a KERNEL payment_request?cards updateexcludes kernel ("kernel cards cannot be updated", :466), butpayment-requests updateallows--provider kerneland its example (shared with create, :515) shows a KERNEL spec. if unsupported, mirror cards update; if supported, the "same lifecycle as the card" help needs a caveat
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d5e9abe. Configure here.
bmsaadat
left a comment
There was a problem hiding this comment.
Holding this until the Shop Pay changes pass a smoke test through the real API (Raf's ask for the SDK bot PRs). The approval above predates the Shop Pay commits. I'll approve as soon as it passes.
bmsaadat
left a comment
There was a problem hiding this comment.
Smoke tested the Shop Pay changes against the prod API with a local build of this branch: wallet connect, card create, spec refusals, authorize at checkout, Shop approval, fill, a real $1 purchase on Kernel's Stripe link, and confirm_transaction (card consumed). All passed.

Summary
738369d524a3806832577f6793dde7eaf15c5725.Coverage
CLI coverage update report
SDK update
github.com/kernel/kernel-go-sdkfromv0.137.0tov0.138.0(SDK commit738369d524a3806832577f6793dde7eaf15c5725).go get github.com/kernel/kernel-go-sdk@738369d524a3806832577f6793dde7eaf15c5725andgo mod tidy.Coverage audit
api.mdand reviewed their parameter structs.x-cli-skip: true:client.ConfigRegistry.Listclient.ConfigRegistry.Lookupclient.ConfigRegistry.Resolveclient.ConfigRegistry.Analyses.Getclient.ConfigRegistry.Analyses.Listclient.ConfigRegistry.Analyses.CancelGap analysis
Missing commands
Missing flags
Changes
Commands and flags
Response output
SDK
v0.138.0adds the browser-session response fieldleased_at. Following OpenAPI fieldcomponents.schemas.Browser.leased_at, the CLI now shows Leased At for leased pooled sessions in human-readable output from:kernel browsers createwhen acquiring through--pool-idor--pool-namekernel browsers getkernel browsers updatekernel browsers list(column shown only when at least one result is leased)kernel browser-pools acquirekernel invoke browsers(column shown only when at least one result is leased)JSON output already includes
leased_atthrough the updated SDK response models. No command Short/Long text or flag usage text needed adjustment because this release changes only a response field, not endpoint or request-field behavior.Intentional exclusions
x-cli-skip: true.x-cli-skip: trueare not exposed as methods in this SDK release and therefore require no CLI command.Validation
go test ./cmd/... ./pkg/...— passed.go build ./...— passed./home/runner/work/_temp/cli-scratch/kerneland smoke-checked help for the affected commands.leased_atvalues.Validation
Note
Medium Risk
Large CLI surface for API keys, auth, browser lifecycle, and payment/vault operations; mistakes in validation or docs could mislead operators in security-sensitive flows, though behavior is mostly delegated to the API.
Overview
Updates the CLI for kernel-go-sdk v0.138.0, wiring new API capabilities into commands, flags, help text, and tests—not just response formatting.
API keys:
createadds--expires-at(RFC3339, exclusive with--days-to-expire) and--policy(JSON allow statements with validation). List/get show Last Used At and support sorting bylast_used_at.Managed auth:
--hitlon create/update pauses unsolved login CAPTCHAs for live-view completion; get/follow surface human intervention state,human_interventionchoices, and Live View URL.Browsers & pools: New
browsers save-profile(overwrite/create profile, restarts session, no SDK retries). Create adds closed-beta--fingerprint-os. Update supports optimistic allowlist changes via--expected-allowlist-revisionand--mutation-id; get shows allowlist revision/mutation. Leased At appears in human output wherever pooled leases returnleased_at. Browser-pools update adds--expected-networkfor stale-network (409) protection.Vaults / payments: Shop Pay wallets and cards,
payment-requests(Link/KERNEL one-shot purchases), walletadd_payment_method/remove_payment_method, richerconfirm_transactionparsing (order/failure fields, Shop Pay transaction types), Linkpayment_requestauthorize/fill parity, typed confirm payloads, and sharedvaultWriteRequestOptions()on vault writes. Help and 1Password flows expand (target_idon1pw_fill, pre-approved access-request specs).Reviewed by Cursor Bugbot for commit d294c78. Bugbot is set up for automated code reviews on this repo. Configure here.