Repository navigation
Upgrade to Go 1.27.3 - #444
Merged
Merged
Conversation
tnsardesai
force-pushed
the
hypeship/go-1.27
branch
from
October 29, 2026 01:21
693e536 to
09ca0d1
Compare
tnsardesai
marked this pull request as ready for review
October 29, 2026 22:52
Contributor
Author
|
Picked sjmiller609 to review: touched the changed code in |
sjmiller609
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This moves the repo from Go 1.26.10 to the latest patch release, Go 1.27.3. Both include the crypto/x509 fix for CVE-2026-111943 (the compromised eMudhra intermediates).
server/go.modgo 1.26.10go 1.27.3Other places that pin the Go toolchain:
images/chromium-headless/image/Dockerfile,images/chromium-headful/Dockerfile:docker.io/golang:1.26.10->docker.io/golang:1.27.3AGENTS.md,server/README.md: required Go versionserver-test,chromium-launcher-test,vuln-remediation) readsgo-version-file: server/go.modOther changes needed for the upgrade:
go mod tidyremoved 349 staleserver/go.sumlines for module versions no longer in the graph.Breaking changes and GODEBUG review
mainis already on Go 1.26.10, so raising thegoline only changes the Go 1.27 default:tracebacklabels=1(pprof goroutine labels are printed in tracebacks). It isn't overridden here (nogodebugblocks,//go:debugorGODEBUGenv).Removed outright in 1.27 (new behavior regardless of the
goline):asynctimerchan,gotypesalias,tls10server,tlsrsakex,tls3des,tlsunsafeekm,x509keypairleaf. None are set here.Toolchain changes that apply as soon as 1.27 builds the code:
encoding/jsonruns on the v2 implementation (same behavior, different error text for some errors), HTTP/1Response.Body.Closedrains unread bodies,go testruns thestdversionvet check, andgofmtalignment changed slightly.Repo-specific findings:
server/builds withCGO_ENABLED=0, andgolang:1.27.3is Debian trixie likegolang:1.26.10, so the builder base distro does not change.cmd/api/api/browser_repl.gorejects unknown request fields by checkingstrings.HasPrefix(err.Error(), "json: unknown field")on aDisallowUnknownFieldsdecode. On go1.27.3 the message is unchanged (json: unknown field "extra", checked for top-level and nested unknown fields), so the check keeps working.== io.EOF, so 1.27 returning a bareio.EOFfromUnixConnreads changes nothing.github.com/kernel/neko/server; the neko base image used by the headful image is built from that repo and is upgraded separately.Verification
kernel-images/server:go build ./...pass,go vet ./...pass. Unit tests perAGENTS.md(go test -race, excludinge2e): 32/32 packages ok on go1.27.3 (baseline onmainwith go1.26.10: 32/32).lib/devtoolsproxy'sTestUpstreamManagerDetectsChromiumAndRestartlaunches a real Chromium and is flaky under load on both toolchains. Run on its own, 3 rounds each, it passed 3/3 on this branch and 2/3 onmain. Each run also leaves Chromium processes behind, which predates this change.server-builderstage of the headless Dockerfile ongolang:1.27.3.server/e2e, which needs prebuiltonkernel/chromium-*-testimages. Build the images and run e2e before merging.Note
Medium Risk
A full-toolchain bump affects every server binary and image build; Go 1.27 default/runtime behavior changes warrant regression testing beyond unit tests (e2e/image builds were not run in the PR).
Overview
This PR bumps the server module and build toolchain from Go 1.26.10 to Go 1.27.3 (including the crypto/x509 fix for CVE-2026-111943 noted in the PR description).
server/go.modsetsgo 1.27.3;go mod tidyshrinksserver/go.sumby dropping checksums for modules no longer in the dependency graph. Docs (AGENTS.md,server/README.md) now state the required Go version.Both Chromium image Dockerfiles use
docker.io/golang:1.27.3for theserver-builderstage, so CI workflows that readgo-version-file: server/go.modwill pick up 1.27.3 on the next run. No application source changes are in the diff—only toolchain pins and the lockfile cleanup.Reviewed by Cursor Bugbot for commit 09ca0d1. Bugbot is set up for automated code reviews on this repo. Configure here.