Repository navigation
Conversation
bytenik
marked this pull request as ready for review
October 23, 2026 14:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changeset files generated by the JavaScript tooling quote package names, such as
"@scope/package": patch. The parser currently keeps those delimiters inPackageName, so consumers cannot match these entries to the package's unquoted name.Strip one matching pair of single or double quotes when parsing package names. Quoted and unquoted entries then contribute to the same release. Consume front-matter lines independently of the number of unique package names so duplicate normalized keys preserve the summary and retain last-entry-wins behavior.
This changes the parsed names exposed by the public API. A major changeset documents the compatibility change, and the format documentation describes quoted names.
Follows the parser-level fix suggested in knope-dev/knope#2051 (comment).
Validation:
cargo test --locked.cargo clippy --locked --all-targets -- -D warnings,cargo +nightly fmt --check, andgit diff --checkpass.