Repository navigation
Require a space after the Basic authentication scheme - #3138
Merged
vishr merged 1 commit intoOct 22, 2026
Merged
Conversation
vishr
approved these changes
Oct 22, 2026
vishr
left a comment
vishr
left a comment
Member
There was a problem hiding this comment.
Reviewed the minimal scheme-boundary check and regression cases. The length check makes the separator access safe; case-insensitive Basic matching is preserved. This fixes parsing and check-limit accounting; valid credentials are still required.
Member
|
Merged with contributor credit. The v4 backport is open at #3188, with a v4-specific regression that rejects BasicX without calling the credential validator. Local race tests and vet pass. |
vishr
added a commit
that referenced
this pull request
Oct 22, 2026
Backport #3138. Reject malformed schemes such as BasicX before decoding credentials or invoking the validator. v4 reads only its first Authorization header and has no AllowedCheckLimit, so its regression covers that API. Co-authored-by: Shubham Padkonde <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BasicAuth checks the
Basicprefix but does not check the following separator. As a result,BasicXfollowed by valid encoded credentials reaches the protected handler. An unrelated scheme with that prefix can also consumeAllowedCheckLimit, preventing a later valid Basic header from being checked.Require the space after the scheme before decoding or counting a header. Case-insensitive Basic matching and the existing invalid-base64 behavior are unchanged.
Both added regression cases fail before the fix. The complete Linux
go test -race ./...suite andgo vet ./...pass afterward.