Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize the temporary FOV map buffer to zero so an out-of-bounds point of view cannot return uninitialized visibility flags.
compute_fov()currently warns about an out-of-bounds point of view and continues. libtcod then returns an error without filling the FOV cells. Since the wrapper allocates those cells withnp.empty, the result can contain stale visibility data. Zero-initialization preserves the existing warning behavior and returns an all-false mask in this case.The regression tests cover all four map boundaries with a poisoned allocation so the failure is deterministic. All four fail before the fix. After the fix, these tests and the existing map tests pass (9 passed). Ruff reports no issues on the changed source and test files.
Validation used the tcod 21.2.2 wheel with only
tcod/map.pyreplaced by the updated file. Before the change, that file was byte-for-byte identical to the current source. A full source build and rendering tests were not run.