Repository navigation
fix(desktop): remove legacy unzipper license gaps - #624
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
gansx
force-pushed
the
gansx/fix-desktop-license-materials
branch
from
October 30, 2026 05:21
ae84b55 to
1c92560
Compare
added 6 commits
October 30, 2026 13:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The desktop candidate build stopped in
Generate version-matched notices, original licenses and SBOMbecause the exact installed versions[email protected]and[email protected](pulled throughexceljs -> [email protected]) did not ship license text.Fix
unzipperdependency to0.11.2, which removes the obsoletebinary -> buffers/chainsawchain and ships its own license material.Validation
pnpm install --frozen-lockfile --ignore-scriptspnpm run check:licensespnpm run check:publicgit diff --checkThe local materials run no longer reports
buffersorchainsawgaps. It remains blocked locally only because this workstation does not have the cloud workflow's gstack candidate resources; the cloud build will regenerate those resources before packaging.