Skip to content

feat: support authentication for rest-crud based APIs - #10546

Draft
aaqilniz wants to merge 3 commits into
loopbackio:masterfrom
aaqilniz:feat/auth-for-rest-crud
Draft

aaqilniz wants to merge 3 commits into
loopbackio:masterfrom
aaqilniz:feat/auth-for-rest-crud

Conversation

@aaqilniz

@aaqilniz aaqilniz commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

There is no way to apply authentication to rest-crud based APIs generated with lb4 rest-crud. This PR provides an idea and a basic implementation for achieving that.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@aaqilniz
aaqilniz force-pushed the feat/auth-for-rest-crud branch 2 times, most recently from e6c50b5 to dda4097 Compare June 14, 2024 07:49
@aaqilniz
aaqilniz force-pushed the feat/auth-for-rest-crud branch 3 times, most recently from 3b6df50 to f5f7536 Compare August 19, 2024 18:44
@aaqilniz
aaqilniz marked this pull request as ready for review August 19, 2024 18:48
@danysz

danysz commented Aug 22, 2024

Copy link
Copy Markdown

can you please try to run again or to test again so it will be available for merging ?

@danysz

danysz commented Aug 27, 2024

Copy link
Copy Markdown

Hello @nabdelgadir , @raymondfeng , what is needed to be able to merge this feature ?

It is really important.

@aaqilniz
aaqilniz force-pushed the feat/auth-for-rest-crud branch from 0e85c89 to effdaa7 Compare August 27, 2024 18:26
@aaqilniz

Copy link
Copy Markdown
Contributor Author

Hi, @danysz. I am working on the tests for the changes. I will update the PR soon.

@aaqilniz
aaqilniz marked this pull request as draft August 27, 2024 18:56
@aaqilniz
aaqilniz force-pushed the feat/auth-for-rest-crud branch 4 times, most recently from a94a67f to 7578677 Compare August 28, 2024 10:32
@aaqilniz
aaqilniz marked this pull request as ready for review August 28, 2024 10:50
@aaqilniz

Copy link
Copy Markdown
Contributor Author

Hi, @samarpanB. Can you help me with the tests? The tests should fail as I have added an authentication decorator but it does not take any effect.

@aaqilniz
aaqilniz marked this pull request as draft October 18, 2026 04:52
@aaqilniz
aaqilniz force-pushed the feat/auth-for-rest-crud branch from 7578677 to ee59089 Compare October 25, 2026 21:12

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants