Repository navigation
Leave out ExifTool GPS points timestamped far from the others - #930
Merged
caglarpir merged 1 commit intoOct 26, 2026
Merged
Conversation
The ExifTool video reader times every point by its GPS timestamp, relative to the first point. A receiver at cold start, or a wrong date, can write a first timestamp far from the others: a dashcam video whose first GPS timestamp was 22 hours older than the next one had every other point 22 hours into the video. Where that overflows the sample duration of the uploaded video, mapillary#929 fails the whole video for one wrong point; below that limit (19.9 hours at a timescale of 60000, 49.7 days at a timescale of 1000), the video was processed and uploaded with its track that far past its end. Before making the times relative to the first point, split the track where two consecutive GPS timestamps are more than MAPILLARY_TOOLS_MAX_GPX_GAP_SECONDS (1 hour) apart, keep the segment with the most points (the earliest of them on a tie), and make the times relative to its first point. The extractor warns once of the points left out. Only the tracks timed by their GPS timestamps are split, the QuickTime, Insta360 and LIGO records; the GoPro tracks that ExifTool reads are timed by their samples and do not change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ExifTool video reader times every point by its GPS timestamp, relative to the first point. A receiver at cold start, or a wrong date, can write a first timestamp far from the others: a dashcam video whose first GPS timestamp was 22 hours older than the next one had every other point 22 hours into the video. Where that overflows the sample duration of the uploaded video, #929 fails the whole video for one wrong point; below that limit (19.9 hours at a timescale of 60000, 49.7 days at a timescale of 1000), the video was processed and uploaded with its track that far past its end.
Before making the times relative to the first point, split the track where two consecutive GPS timestamps are more than
MAPILLARY_TOOLS_MAX_GPX_GAP_SECONDS(1 hour) apart, keep the segment with the most points (the earliest of them on a tie), and make the times relative to its first point. The extractor warns once of the points left out, e.g. "1 GPS point of VIDEO was left out: its GPS timestamp is more than 3600 s from those of the other 60 points". Only the tracks timed by their GPS timestamps are split, the QuickTime, Insta360 and LIGO records; the GoPro tracks that ExifTool reads are timed by their samples and do not change. #929's check stays, for the tracks of other sources.process --video_geotag_source exiftool_xml: 60 points from 0 to 59 s and one warning, the same track as from the unchanged XML. Main: 61 points, 60 of them 22 hours past the end of the 59 s video, and ready. The copy of the GPS log in the embedded low resolution recording keeps its right first timestamp, and is still not doubled.MapillaryGPSPointsTooFarApartError.process_and_upload --video_geotag_source exiftool_runtime: all three are uploaded, one warning. Main: that video fails.Read through ExifTool, the tracks of 603 videos of many cameras, timelapses and BlackVue videos included, do not change, and none has a point left out. Compared with main on
process,video_processandprocess_and_upload --dry_run, on images and videos of many cameras with the default and other sources, the outputs and exit codes are the same.Unit and integration tests, doctests,
mypy --python-version 3.9,ruff check,ruff format --checkandusort diffare clean.