Repository navigation
P0 #707: truthfully report static RCB zero-ingress state in Copy Diagnostic - #761
Merged
masarray merged 2 commits intoOct 27, 2026
Conversation
masarray
marked this pull request as ready for review
October 27, 2026 23:10
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
masarray
merged commit Oct 27, 2026
e7b1943
into
release/arsas-integrated-rc0-20261024
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P0 SG7_BCU recurrence: expose zero-frame RCBs in existing Copy Diagnostic (read-only)
Why: Operator-accepted 2026-10-24/25 FAT showed SG7
77/77and4/4independently routed static RCBs; 2026-10-28 RC EXE reverted observationally to56/77,1/4. Comparing Git file blob SHA proved the exact monitoring, activation, projection, engine pin and primary GUI files identical between working FAT and RC. This PR does not assume source regression or IED culpability.Changes (two files only)
Services/DiagnosticReportBuilder.cs: add a boundedStatic RCB trafficsection to the existing operator Copy Diagnostic, usingStaticDataSetRcbImageTriage.Evaluate(existing read-only immutable snapshot projection). Displays exact per-RCB DataSet image-visible/pending, frames, RptEna/GI evidence when actually in observed stream, truthfulunverifiedfor silent RCBs,ROUTEDvsNO ROUTED FRAMES. No different RCB's proof can be borrowed.tests/ARSAS.Tests/StaticDataSetInitialImageDiagnosticTests.cs: positive 1 active/1 silent SG7 RCB and null/no-snapshot negative fixture. Assert no unsupported activation acceptance is fabricated.Safeguards and scope
Zero new MMS traffic, no RptEna/GI/Resv/Owner writes, no polling fallback, no device capture, no report route or SSOT semantics changed. No modified WPF/UI and no changes to ARIEC lock. Diagnostic is evaluated only on explicit Copy Diagnostic action, max 16 groups. This is not a root-cause fix; it improves the next diagnosis of whether RCBs were quiet vs silently decoded/routed and keeps monitoring safety intact.
Exact base
d4598619b1b8fc21487cf5beb83a8a8284d0e9cf(release/arsas-integrated-rc0-20261024); branch sourcef22704b859d7bf7a7afa207a03a21231215b13d4. Diff verified: exactly two text files, 69 changed lines. Draft until exact-head CI and source review. Do not merge tomainor promote stable. Track recurrent behavior in #707 without reopening old FAT/re-capture obligations.