Repository navigation
feat(M4-P0E3B2): boot-scoped reconnect roster probe and V1 overwrite guard - #349
Merged
Merged
Conversation
Probe boot-scoped MULTISV SHOW on a verified M4-capable board before V1 auto PROFILE, confirm configured/selected roster and three identities with read-only three-bank inspection, or block on incomplete/timeout evidence. No automatic START, GUI draft mutation, second serial owner or CI workflow expansion. Cover selected and invalid roster reconnect in existing S8 harness.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Prevent same-COM reboot deviceIdentityChanged from triggering V1 auto-sync in the interval before M4 roster discovery. Probe only after new boot identity applied. No additional workflows.
7 tasks
… observers Fail closed from UNKNOWN to PENDING for M4 boot probes, only enter LEGACY on non-M4 firmware or verified unselected firmware mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meaningful safety milestone
On every semantically verified M4-capable ESP32-P4 session (and same-COM firmware reboot), a bounded
MULTISV SHOWboot-scoped probe establishes whether the board has selected a three-SV roster before Studio's automatic V1 PROFILE sync can write.PENDING/UNKNOWNblock V1 and START;SELECTEDinhibits V1 and initiates existing read-only 3-MU bank inspection, preserving autonomous RUNNING and GUI drafts; explicitly unselected healthy board remains legacy-capable. Wait for serialcommandTransmitted, require STATUS+TXMODE+three STREAM rows, bound to boot and 5-second deadline. No new serial thread, firmware hot-path changes or CI matrix/workflow. Extend existing S8 deterministic harness for selected and malformed responses.Safety boundary: Board selected-roster identity still requires exact SCD matching for production group START; group START remains blocked. Physical 12kfps/PTP validation remains P0F. Tracks #333. Please review reconnect fail-closed semantics and CI exact-head before merge.