Repository navigation
0.13.2: a bounded wait for a program started with a bound lifetime - #36
Merged
Merged
Conversation
…its for it Co-authored-by: speak-agent <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kal_timeout_wait_processread a process word as a handle (okw::unpack(p.h)). A program started withKAL_SPAWN_BOUND_LIFETIMEis named by its record (kindbound), so every bounded wait for it failed with an error. A caller that bounds a command then waited without the bound: mcpp's[hooks] timeout_secondsdid not stop a hook on Windows (mcpp e2e 317: the five-second hook ran to its end), and its polls of a running program (try_wait) never saw it end.The wait now resolves the word as every other operation of process.cpp does (
process_of, exposed asokw::process_handle).tests/bounded_wait_of_a_bound_program.cpp: a boundcmd /c ping -n 3is waited for with a 100 ms bound (expires) and then with a 20 s bound (ends, status 0); a boundcmd /c exit 3reports 3.Co-authored-by: speak-agent [email protected]